Bug 2249001

Summary:	When creating a new pool, we show device type HDD without an option to select SSD
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Sanjal Katiyar <skatiyar>
Component:	management-console	Assignee:	Sanjal Katiyar <skatiyar>
Status:	CLOSED ERRATA	QA Contact:	Parag Kamble <pakamble>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.13	CC:	ebenahar, etamir, kbg, kramdoss, muagarwa, nthomas, odf-bz-bot, sapillai, skatiyar, srozen
Target Milestone:	---
Target Release:	ODF 4.12.12
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.12.12-1	Doc Type:	Bug Fix
Doc Text:	Previously, for the internal OpenShift Data Foundation installations, the user interface showed HDD, SSD, or both in the Volume type dropdown for the existing clusters. However, for all the internal deployments, it should be assumed that the disks are SSD as that is the only volume type supported. With this fix, Volume type dropdown is removed from the user interface and always assume it to be SSD.	Story Points:	---
Clone Of:	2241179	Environment:
Last Closed:	2024-04-04 06:27:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2239622, 2241179
Bug Blocks:

Description Sanjal Katiyar 2023-11-10 06:26:17 UTC

+++ This bug was initially created as a clone of Bug #2241179 +++

+++ This bug was initially created as a clone of Bug #2239622 +++

Description of problem (please be detailed as possible and provide log
snippests):
When creating a new pool, we show device type HDD without an option to select SSD. 
We should hide this field and use only SSD. 

Can this issue reproducible?
Yes. Simply create a new pool

Can this issue reproduce from the UI?
Yes. It's a UI bug

If this is a regression, please provide more details to justify this:

Can't tell

--- Additional comment from RHEL Program Management on 2023-09-19 12:51:16 UTC ---

This bug having no release flag set previously, is now set with release flag 'odf‑4.14.0' to '?', and so is being proposed to be fixed at the ODF 4.14.0 release. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag.

--- Additional comment from Sanjal Katiyar on 2023-09-19 13:08:49 UTC ---

for more details: https://ibm-systems-storage.slack.com/archives/C04T78XKSDR/p1694835311121999

currently UI reads this value from CephCluster CR's status: https://rook.io/docs/rook/v1.11/CRDs/Cluster/ceph-cluster-crd/#other-status (cephCluster.status.storage.deviceClasses) and display it as available "Volume type" on the "Create BlockPool" page.
we need to ignore the status and always assume it as "SSD" by default and hide this dropdown field on the UI.

--- Additional comment from Sanjal Katiyar on 2023-09-19 13:10:09 UTC ---

as per discussion with Eran, need to backport to 4.13 and 4.12 as well.

--- Additional comment from Mudit Agarwal on 2023-09-19 13:11:53 UTC ---

Santosh, JFYI. We should have addressed this in https://issues.redhat.com/browse/RHSTOR-4326?

--- Additional comment from RHEL Program Management on 2023-09-20 12:14:59 UTC ---

This BZ is being approved for ODF 4.14.0 release, upon receipt of the 3 ACKs (PM,Devel,QA) for the release flag 'odf‑4.14.0

--- Additional comment from RHEL Program Management on 2023-09-20 12:14:59 UTC ---

Since this bug has been approved for ODF 4.14.0 release, through release flag 'odf-4.14.0+', the Target Release is being set to 'ODF 4.14.0

--- Additional comment from errata-xmlrpc on 2023-09-21 04:10:20 UTC ---

This bug has been added to advisory RHBA-2023:115514 by ceph-build service account (ceph-build.COM)

--- Additional comment from Santosh Pillai on 2023-09-21 06:49:40 UTC ---

(In reply to Mudit Agarwal from comment #4)
> Santosh, JFYI. We should have addressed this in
> https://issues.redhat.com/browse/RHSTOR-4326?

RHSTOR-4326 was for the new OSDs only. We don't have a way in Rook to automatically change the Deviceclass of existing OSDs.
But agree that we should have discussed the pool creation UI flow when discussing RHSTOR-4326. I didn't know that the UI was reading the inputs from `cephCluster.status.storage.deviceClasses`

--- Additional comment from Sanjal Katiyar on 2023-09-28 12:11:49 UTC ---

for adding this fix in 4.13.z release of ODF...

--- Additional comment from RHEL Program Management on 2023-09-28 12:12:07 UTC ---

This bug having no release flag set previously, is now set with release flag 'odf‑4.14.0' to '?', and so is being proposed to be fixed at the ODF 4.14.0 release. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag.

--- Additional comment from RHEL Program Management on 2023-09-28 12:12:07 UTC ---

The 'Target Release' is not to be set manually at the Red Hat OpenShift Data Foundation product.

The 'Target Release' will be auto set appropriately, after the 3 Acks (pm,devel,qa) are set to "+" for a specific release flag and that release flag gets auto set to "+".

--- Additional comment from RHEL Program Management on 2023-10-27 09:01:36 UTC ---

This BZ is being approved for an ODF 4.13.z z-stream update, upon receipt of the 3 ACKs (PM,Devel,QA) for the release flag 'odf‑4.13.z', and having been marked for an approved z-stream update

--- Additional comment from RHEL Program Management on 2023-10-27 09:01:36 UTC ---

Since this bug has been approved for ODF 4.13.5 release, through release flag 'odf-4.13.z+', and appropriate update number entry at the 'Internal Whiteboard', the Target Release is being set to 'ODF 4.13.5'

--- Additional comment from Sunil Kumar Acharya on 2023-10-27 11:18:02 UTC ---

Please backport the fix to ODF-4.13 and update the RDT flag/text appropriately.

--- Additional comment from Sanjal Katiyar on 2023-10-30 10:30:23 UTC ---

(In reply to Sunil Kumar Acharya from comment #6)
> Please backport the fix to ODF-4.13 and update the RDT flag/text
> appropriately.

done...

--- Additional comment from errata-xmlrpc on 2023-11-06 11:14:44 UTC ---

This bug has been added to advisory RHBA-2023:123491 by ceph-build service account (ceph-build.COM)

--- Additional comment from errata-xmlrpc on 2023-11-08 18:14:40 UTC ---

Advisory RHBA-2023:123491 expected publication date changed from 2023-05-30 to 2023-12-04

Comment 5 krishnaram Karthick 2024-01-02 14:01:52 UTC

4.12.11 content finalization was complete and this fix was not part of it. 
moving the bug to next z stream.

Comment 13 errata-xmlrpc 2024-04-04 06:27:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Data Foundation 4.12.12 Bug Fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:1673