Bug 2249439

Summary: Review Request: rust-colorgrad - Rust color scales library
Product: [Fedora] Fedora Reporter: Leo Puvilland <leo>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/colorgrad
Whiteboard:
Fixed In Version: michel@michel-slm.name Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-18 18:55:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841    

Comment 1 Fedora Review Service 2023-11-13 02:52:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6627794
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249439-rust-colorgrad/fedora-rawhide-x86_64/06627794-rust-colorgrad/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2023-11-14 17:27:14 UTC
Can you restore the comment that rust2rpm generates? It helps to keep track of packages generated by older rust2rpm

Also - the Pagure repo will hopefully be short-lived since once this is reviewed you will end up with a repo in src.fedoraproject.org/rpms - it's fine to use Pagure for your own repos but I'd suggest creating a group named after your FAS username, and putting your personal repo underneath.

Comment 3 Leo Puvilland 2023-11-14 19:54:35 UTC
Comment restored.

Comment 4 Michel Lind 2023-11-14 22:27:25 UTC
Thanks! Doing some installation tests now to verify everything works, going to leave the laptop running this as the wifi situation is sad.

One note: you'd want to target Rawhide for your Koji scratch build next time, not Fedora 39 - new packages must be build for Rawhide (unless they are EPEL-only packages), but they don't necessarily have to be built for released branches.

Comment 5 Leo Puvilland 2023-11-15 03:21:56 UTC
Good to know, thank you :)
New Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109048580

Comment 6 Michel Lind 2023-11-15 14:34:30 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 7 Fedora Review Service 2023-11-15 14:34:56 UTC
Hello @leo,
since this is your first Fedora package, you need to get sponsored by a package
sponsor before it can be accepted.

A sponsor is an experienced package maintainer who will guide you through
the processes that you will follow and the tools that you will use as a future
maintainer. A sponsor will also be there to answer your questions related to
packaging.

You can find all active sponsors here:
https://docs.pagure.org/fedora-sponsors/

I created a sponsorship request for you:
https://pagure.io/packager-sponsors/issue/603
Please take a look and make sure the information is correct.

Thank you, and best of luck on your packaging journey.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 8 Michel Lind 2023-11-15 14:45:00 UTC
I've sponsored you into the packager group

https://accounts.fedoraproject.org/user/leo/

You'll need to log out and log back into src.fedoraproject.org before your permissions take effect, if I remember correctly

Please follow these steps if you have not already: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/#join_the_important_mailing_lists

and feel free to ask me any question (on the Rust Matrix, or direct message to @ salimma : fedora.im or email to salimma @ fedoraproject . org)


Next steps: https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/#add_package_to_source_code_management_scm_system_and_set_owner

(and you can delete the Pagure repo after you're done)

Comment 9 Fedora Admin user for bugzilla script actions 2023-11-15 16:46:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-colorgrad

Comment 10 Leo Puvilland 2023-11-18 18:55:05 UTC
Pushed to Bodhi.