Bug 2249882
| Summary: | Review Request: rust-emojis - Lookup emoji in *O(1)* time! | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luna Sơn Lâm Puvilland <leo> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/emojis | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-11-16 00:45:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 201449 | ||||||
| Attachments: |
|
||||||
|
Description
Luna Sơn Lâm Puvilland
2023-11-15 18:56:28 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6639735 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249882-rust-emojis/fedora-rawhide-x86_64/06639735-rust-emojis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good in general, only two minor issues: - The summary is way too long. Please replace the "Summary" tag in the package with something more concise. - The spec file inside the uploaded SRPM does not match the uploaded spec file. Make sure they match. Additionally, please update the the summary in the bug title according to whatever shortened Summary you come up with. Spec URL: https://pagure.io/leo/rpms-wip/raw/master/f/rust-emojis/rust-emojis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/rpms-wip/srpm-builds/06695931/rust-emojis-0.6.1-1.src.rpm Created attachment 2001567 [details]
The .spec file difference from Copr build 6639735 to 6695932
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695932 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249882-rust-emojis/fedora-rawhide-x86_64/06695932-rust-emojis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks, looks better now.
Upon closer inspection of the source code, I found some code that is generated from Unicode data ("src/gen/*.rs"):
https://unicode.org/Public/emoji/15.1/emoji-test.txt
Code generated from this data is usually covered by the terms of the "Unicode Data Files and Software License" (Unicode-DFS-2016):
https://www.unicode.org/copyright.html
https://www.unicode.org/license.txt
Please ask the upstream project to clarify the license of these files. If they are indeed covered by the terms of the Unicode-DFS-2016 license, the crate metadata should probably reflect that, and the text of the license in a file (like "LICENSE-UNICODE") should be included - similarly to what https://github.com/dtolnay/unicode-ident does.
Are you still interested in this package? This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |