Bug 2250425

Summary: Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more
Product: [Fedora] Fedora Reporter: Seth Maurice-Brant <fedoraproject.kwudj>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-22 20:19:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Seth Maurice-Brant 2023-11-18 13:02:48 UTC
Spec URL: https://saluki.fedorapeople.org/golang-github-jinzhu-copier.spec
SRPM URL: https://saluki.fedorapeople.org/golang-github-jinzhu-copier-0.4.0-1.fc40.src.rpm

Description:
Copier for golang, copy value from struct to struct and more.

Fedora Account System Username: saluki

Comment 1 Seth Maurice-Brant 2023-11-18 13:02:50 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109206539

Comment 2 Seth Maurice-Brant 2023-11-18 13:03:47 UTC
Other review requests for this package have all long been abandoned. Creating a new one rather than reviving an old and likely outdated bug.

(NTS: depend for yq)

Comment 3 Fedora Review Service 2023-11-18 22:29:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6666939
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250425-golang-github-jinzhu-copier/srpm-builds/06666939/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Seth Maurice-Brant 2023-11-18 22:48:23 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2023-11-18 22:53:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6666975
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250425-golang-github-jinzhu-copier/fedora-rawhide-x86_64/06666975-golang-github-jinzhu-copier/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression '# FIXME'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Michel Lind 2024-04-22 20:17:13 UTC
You'll want to remove this section


# REMOVE BEFORE SUBMITTING THIS FOR REVIEW
# ---
# New Fedora packages should use %%gometa -f, which makes the package
# ExclusiveArch to %%golang_arches_future and thus excludes the package from
# %%ix86. If the new package is needed as a dependency for another package,
# please consider removing that package from %%ix86 in the same way, instead of
# building more go packages for i686. If your package is not a leaf package,
# you'll need to coordinate the removal of the package's dependents first.
# ---
# REMOVE BEFORE SUBMITTING THIS FOR REVIEW

also, the license section is missing

Comment 7 Michel Lind 2024-04-22 20:19:07 UTC

*** This bug has been marked as a duplicate of bug 2276516 ***