Bug 2250572
| Summary: | Review Request: rust-enum-ordinalize - Construct enum variant from its ordinal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/enum-ordinalize | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-11-29 21:52:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2250569 | ||||||
| Attachments: |
|
||||||
|
Description
Daiki Ueno
2023-11-20 00:01:57 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6670540 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250572-rust-enum-ordinalize/srpm-builds/06670540/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://ueno.fedorapeople.org/rust-enum-ordinalize/rust-enum-ordinalize.spec SRPM URL: https://ueno.fedorapeople.org/rust-enum-ordinalize/rust-enum-ordinalize-3.1.15-1.fc40.src.rpm [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/6671889 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250572-rust-enum-ordinalize/fedora-rawhide-x86_64/06671889-rust-enum-ordinalize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks pretty good, but the Summary is much too long. Please trim the Summary tag to something that's more sensible, maybe like """ Summary: Construct enum variant from its ordinal """ Once that is done, please also update the bug title accordingly. Thank you for the suggestion, updated the Summary. Spec URL: https://ueno.fedorapeople.org/rust-enum-ordinalize/rust-enum-ordinalize.spec SRPM URL: https://ueno.fedorapeople.org/rust-enum-ordinalize/rust-enum-ordinalize-3.1.15-1.fc40.src.rpm [fedora-review-service-build] Created attachment 2000831 [details]
The .spec file difference from Copr build 6671889 to 6677780
Copr build: https://copr.fedorainfracloud.org/coprs/build/6677780 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250572-rust-enum-ordinalize/fedora-rawhide-x86_64/06677780-rust-enum-ordinalize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you for the update! Looks good to me now, with one minor caveat noted at the bottom. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === There is a newer release of this crate available (v4, with the latest being v4.2.0). But if you explicitly need v3 for what you're working on, then packaging v3.1.15 (the most recent version in the v3 series) is fine. (In reply to Fabio Valentini from comment #8) > There is a newer release of this crate available (v4, with the latest being > v4.2.0). > But if you explicitly need v3 for what you're working on, then packaging > v3.1.15 (the most recent version in the v3 series) is fine. Thank you for the review. As this is for rust-educe, whose upstream still requires ^3.1 of enum-ordinalize, I would go with v3 for now. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum-ordinalize The package has been imported and built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7decf6f42f |