Bug 2250689

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109302890

This package is needed for the #2245786 python-xlmmacrodeobfuscator, #1974565 new version 0.60.1 of oletools

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6670535
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250689-python-untangle/srpm-builds/06670535/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Need to change to newer python guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Unless there is a good reason.
I think this is just using this bit

%build                                                                                                                            
%pyproject_wheel                                                                                                                  
                                                                                                                                  
%install                                                                                                                          
%pyproject_install                                                                                                                
                                                                                                                                  
%py3_shebang_fix %{buildroot}%{python3_sitelib}/untangle.py    

and in %files

%{python3_sitelib}/untangle-%{version}.dist-info  

--
URL:            https://github.com/stchris/untangle                                                                               
Source0:        https://github.com/stchris/untangle/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz 

Source0 can be simplified by use of %{url}

--

My local fedora-review shows this problem in the original 
python3-untangle.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/untangle.py 644 /usr/bin/env python  
which may be fixed by the shebang_fix line above.

I would love to use pyproject macros, but these are not available in epel7 at all and having problems in epel8 and I would like to keep maintaining just one spec.file if possible.
As it is it builds for all supported epel / fedora branches:
https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6760559/

(In reply to Michal Ambroz from comment #5)
> I would love to use pyproject macros, but these are not available in epel7
> at all and having problems in epel8 and I would like to keep maintaining
> just one spec.file if possible.
Sounds fine.  Please add this as a comment to the spec file and address the couple of other issues.

Spec URL: https://rebus.fedorapeople.org/python-untangle.spec
SRPM URL: https://rebus.fedorapeople.org/python-untangle-1.2.1-2.fc39.src.rpm

Hello Tom,
here is the update. I have removed the mentioned shebang and reported upstream.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916394
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250689-python-untangle/fedora-rawhide-x86_64/06916394-python-untangle/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks fine.
Thanks for the changes
Approved.

Thank you

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-untangle

FEDORA-2024-1d5171cb15 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d5171cb15

FEDORA-EPEL-2024-6d14702bbd has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6d14702bbd

FEDORA-2024-66ca9d4e05 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-66ca9d4e05

FEDORA-EPEL-2024-3bb3562f47 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3bb3562f47

FEDORA-EPEL-2024-72f5662573 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-72f5662573

FEDORA-2024-1d5171cb15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1d5171cb15 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d5171cb15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2024-3bb3562f47 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3bb3562f47

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2024-72f5662573 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-72f5662573

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2024-6d14702bbd has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6d14702bbd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-66ca9d4e05 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-66ca9d4e05 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-66ca9d4e05

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-66ca9d4e05 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2024-3bb3562f47 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-1d5171cb15 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2024-6d14702bbd has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2024-72f5662573 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.