Bug 2251053

Summary:	amd-ucode-firmware subpackage is not pulled as a dependency on x86_64
Product:	[Fedora] Fedora	Reporter:	Timothée Ravier <travier>
Component:	linux-firmware	Assignee:	David Woodhouse <dwmw2>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dwmw2, jforbes, joe, jwboyer, kernel-maint, laura, miabbott, pbrobinson
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	linux-firmware-20231211-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-15 01:32:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Timothée Ravier 2023-11-22 15:43:57 UTC

As far as I understand, linux-firmware is a noarch package and thus the %ifarch x86_64 condition never matches during the package build and thus the subpackage is not added as a Recommends/Requires to linux-firmware.

See: https://gitlab.com/fedora/ostree/sig/-/issues/11

```
[root@743ed7cdecc9 /]# rpm -qp --recommends linux-firmware-20231111-1.fc40.noarch.rpm | grep amd
amd-gpu-firmware
[root@743ed7cdecc9 /]# rpm -qp --requires linux-firmware-20231111-1.fc40.noarch.rpm | grep amd


[root@cb4abf0eb2b9 /]# rpm -qp --recommends linux-firmware-20231111-1.fc39.noarch.rpm | grep amd
amd-gpu-firmware
[root@cb4abf0eb2b9 /]# rpm -qp --requires linux-firmware-20231111-1.fc39.noarch.rpm  | grep amd

```

Reproducible: Always




Not sure how to fix this. We can manually include it in comps or Atomic images for now.

Comment 1 Timothée Ravier 2023-11-22 15:44:47 UTC

Introduced with https://src.fedoraproject.org/rpms/linux-firmware/c/35ec41dbd5754ddaeb75d563d6822157d10307c0?branch=rawhide

Comment 2 Timothée Ravier 2023-11-22 15:48:29 UTC

https://stackoverflow.com/questions/55579036/one-spec-file-to-support-multiple-architectures might be relevant.

Comment 3 Peter Robinson 2023-11-22 16:12:07 UTC

Yep, I am aware of the issue, I have basically reverted it locally. It will eventually be dropped as a hard dep so if it's explicitly needed you should be including it explicitly because the hard dep will go away

Comment 4 Timothée Ravier 2023-11-22 17:52:59 UTC

We'll explicitly include it in FCOS: https://github.com/coreos/fedora-coreos-config/pull/2739

We likely need to make a comps PR for all other variants.

Comment 5 Timothée Ravier 2023-11-22 18:04:34 UTC

Made https://pagure.io/fedora-comps/pull-request/910

Comment 6 Fedora Update System 2023-12-13 18:44:29 UTC

FEDORA-2023-dc46227ed3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dc46227ed3

Comment 7 Fedora Update System 2023-12-14 01:29:26 UTC

FEDORA-2023-dc46227ed3 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-dc46227ed3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-dc46227ed3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-12-15 01:32:42 UTC

FEDORA-2023-dc46227ed3 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.