Bug 2251280

Summary:	Review Request: kdsoap-ws-discovery-client - Library for finding WS-Discovery devices in the network using Qt6 and KDSoap
Product:	[Fedora] Fedora	Reporter:	Alessandro Astone <ales.astone>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://invent.kde.org/libraries/kdsoap-ws-discovery-client/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-31 21:58:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alessandro Astone 2023-11-23 20:15:43 UTC

Spec URL: https://aleasto.fedorapeople.org/reviews/kdsoap-ws-discovery-client/kdsoap-ws-discovery-client.spec
SRPM URL: https://aleasto.fedorapeople.org/reviews/kdsoap-ws-discovery-client/kdsoap-ws-discovery-client-0.3.0-1.fc40.src.rpm
Description: Library to access the usage statistics data collected by the KDE activity manager
Fedora Account System Username: aleasto

Comment 1 Fedora Review Service 2023-11-23 20:19:02 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6685817
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251280-kdsoap-ws-discovery-client/fedora-rawhide-x86_64/06685817-kdsoap-ws-discovery-client/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Alessandro Astone 2023-11-24 13:00:11 UTC

Build failed for a missing kdsoap update that will be pushed as part of a side-tag together with this

Comment 3 Neal Gompa 2023-11-24 13:07:17 UTC

Review notes:

* Package follows Fedora Packaging Guidelines (with one exception)
* Package builds and installs with updated kdsoap
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, please fix the glob for the library on import, it's too greedy. (Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files)

PACKAGE APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2023-11-24 13:21:15 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/kdsoap-ws-discovery-client