Bug 2251436

Summary: Review Request: xcb-util-errors - XCB utility library that gives readable names to error, event, & request codes
Product: [Fedora] Fedora Reporter: Aleksei Bavshin <alebastr89>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://xcb.freedesktop.org
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-04 01:34:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Aleksei Bavshin 2023-11-25 00:17:50 UTC
Spec URL: https://alebastr.fedorapeople.org/review/xcb-util-errors/xcb-util-errors.spec
SRPM URL: https://alebastr.fedorapeople.org/review/xcb-util-errors/xcb-util-errors-1.0.1-1.fc40.src.rpm
Description:
xcb-util-errors is a utility library that gives human readable names to error
codes and event codes and also to major and minor numbers. The necessary
information is drawn from xcb-proto's protocol descriptions.
This library is especially useful when working with extensions and is mostly
useful for debugging.

Fedora Account System Username: alebastr

Comment 1 Fedora Review Service 2023-11-25 04:39:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6693122
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251436-xcb-util-errors/fedora-rawhide-x86_64/06693122-xcb-util-errors/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-11-25 11:13:59 UTC
Review notes:

* Package follows Fedora Packaging Guidelines (with one exception)
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, please fix the glob for the library on import, it's not correct for tracking abi versions. (Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files)

PACKAGE APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-11-25 16:28:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/xcb-util-errors

Comment 4 Fedora Update System 2023-11-25 17:04:10 UTC
FEDORA-2023-f67b040931 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f67b040931

Comment 5 Fedora Update System 2023-11-25 17:17:10 UTC
FEDORA-2023-8765cb3194 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8765cb3194

Comment 6 Fedora Update System 2023-11-26 04:24:27 UTC
FEDORA-2023-f67b040931 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f67b040931 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f67b040931

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-11-26 04:34:54 UTC
FEDORA-2023-8765cb3194 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8765cb3194 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8765cb3194

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-12-04 01:34:30 UTC
FEDORA-2023-f67b040931 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-12-04 01:50:49 UTC
FEDORA-2023-8765cb3194 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.