Bug 2251958

Summary:	global registration command should not execute bash when an error occured
Product:	Red Hat Satellite	Reporter:	Evgeni Golov <egolov>
Component:	Registration	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED MIGRATED	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.14.0	CC:	lstejska, nalfassi, rlavi
Target Milestone:	Unspecified	Keywords:	MigratedToJIRA, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-06 16:37:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Evgeni Golov 2023-11-28 16:34:03 UTC

Description of problem:
Today we call `curl -sS … | bash`, which means that if curl for some reason fails, bash is still executed.
This especially means that if curl fetches an error page, the error page is executed:

bash: line 1: html: No such file or directory
bash: line 2: head: No such file or directory
bash: line 3: !--: No such file or directory
bash: line 4: !--: No such file or directory
bash: line 5: meta: No such file or directory
bash: line 6: title: No such file or directory
bash: line 7: style: No such file or directory
bash: line 8: BODY: command not found
bash: line 9: font-family: command not found
bash: line 9: $'\r': command not found
bash: line 10: font-size: command not found
...
bash: line 71: tr: No such file or directory
bash: line 72: syntax error near unexpected token `<'
'ash: line 72: `    <td><blockquote>

If we call curl with -sSf, it will not output the error page and will not try to execute possibly bad code on the user system.

Version-Release number of selected component (if applicable):
all of them

How reproducible:
100%

Steps to Reproduce:
1. make the registration template endpoint return an error
2. call curl | bash

Actual results:
see above

Expected results:
errored out, no bad commands executed

Additional info:

Comment 1 Eric Helms 2024-06-06 16:37:09 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "SAT-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.