Bug 225207

I'll sponsor Michael.

Created attachment 147432 [details]
rpmlint results


MUST:
* name good
* spec name good
* license good
* license matches
* licenses are in %doc for all subpackages
* spec is English
* spec is legible
* sources match
* package builds on mock for i386 and x86_64 at least, didn't try ia64
* comment present for ExclusiveArch
* BRs OK
* no locales used
* ldconfig used in %post and %postun properly
* not relocatable
* package owns its directories
* no duplicate files
* defattr present for each subpackage
* %clean ok
* consistent use of macros
* packages contain code, not content
* extra docs not presently being built, will be in -devel when they
  are.	No need for a -doc subpackage.
* nothing in %doc needed at runtime
* headers and static libs in -devel package
* no .pc files
* -devel has the unversioned lib*.so files
* -devel properly requires name = %{version}-%{release}
* no GUI -> no .desktop
* no directory ownership problems

SHOULD:
* source includes licenses
* string translations not available
* package builds in mock
* package builds on all supported arches
* package runs as expected
* scriptlets sane
* subpackages properly Require parent
* no pkgconfig files

Packaging Guidelines
* changelog ok
* tags ok
* buildroot ok
* summary and descriptions ok
* encoding ok
* docs ok
* optflags ok
* no static linked bins
* no system lib duplication
* no rpath
* no config files
* no desktop files
* consistent macros
* no %makeinstall
* no locale
* cp -a used
* smp_mflags used
* scriptlets ok

You can ignore the rpmlint error about missing the ldconfig symlink,
as it's present in the -devel package as PackagingGuidelines require.

Bugs:
* Docs permissions are 755, not 644
* source files, thus /usr/src/debug/* are 755, not 644
* package includes *.la files, need to be rm'd in %install and not
installed in %files.
* Obsoletes, but doesn't Provide, a couple packages
* -libs Summary ends with a .
* -devel %doc should include additional licenses of boost (boost
  1.0, which is GPL-compatible)
* add getopts (3-clause BSD) license to all %docs
* add a MANIFEST in %doc noting which parts are covered by which
license.
* trivial rpmlint cleanups for spelling and the like


APPROVED with the above trivial fixes

Also, just a minor comment: The ExclusiveArch only has i386, which means that if
a user tried to build it on an i686 system it would fail, for example. It is
likely better to use %{ix86} here (which expands via RPM to the list of 'i386
i486 i586 i686'). Thanks.

Changes included in libsmbios 0.10.2. Will post new spec/srpm shortly and update
bugzilla.

- Fixed ExlusiveArch %{ix86}

- fixed permissions
- removed *.la files
- added Provides: for Obsoletes:
- fixed -libs summary
- added boost license file to -devel
- added getopts license to all %docs
- fixed speling erors

New version posted.

http://linux.dell.com/libsmbios/download/libsmbios/libsmbios-0.13.2/libsmbios.spec
http://linux.dell.com/libsmbios/download/libsmbios/libsmbios-0.13.2/libsmbios-0.13.2-1.fc6.src.rpm

All of the above changes have been implemented.

Looks good, thanks for making those changes.  APPROVED.

New Package CVS Request
=======================
Package Name: libsmbios
Short Description: Library for accessing BIOS information tables
Owners: mebrown,matt_domsch
Branches: devel
InitialCC: michael_e_brown

By the newly ratified process, please keep the reviewer assigned both durnig and
after the review.

Request CVS Branches for:
  FC-6
  EPEL-4
  EPEL-5