Bug 2252396
Summary: | [rgw][s3select]: rgw going down executing query "select count() from s3object;" on a 10GB csv file | ||
---|---|---|---|
Product: | [Red Hat Storage] Red Hat Ceph Storage | Reporter: | Hemanth Sai <hmaheswa> |
Component: | RGW | Assignee: | gal salomon <gsalomon> |
Status: | CLOSED ERRATA | QA Contact: | Hemanth Sai <hmaheswa> |
Severity: | high | Docs Contact: | Akash Raj <akraj> |
Priority: | unspecified | ||
Version: | 7.0 | CC: | akraj, ceph-eng-bugs, cephqe-warriors, gsalomon, mbenjamin, mkasturi, tserlin |
Target Milestone: | --- | ||
Target Release: | 7.1 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ceph-18.2.1-169.el9cp | Doc Type: | Bug Fix |
Doc Text: |
.An error message is now shown per wrong CSV object structure
Previously, a CSV file with unclosed double-quotes would cause an assert, followed by a crash.
With this fix, an error message is introduced which pops up per wrong CSV object structure.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2024-06-13 14:18:31 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 2267614, 2298578, 2298579 |
Description
Hemanth Sai
2023-12-01 12:17:03 UTC
the file contains not-closed-double-quote, combined with the fact that objects are split into chunks, it may create a bad flow that causes a crash(an assert turned on). this should be avoided. the query should end with an appropriate error message. the crash is fixed on https://github.com/ceph/ceph/pull/55969 upon a mismatch in CSV, such as a missing quote it will issue an error report. (In reply to gal salomon from comment #2) > the crash is fixed on https://github.com/ceph/ceph/pull/55969 > upon a mismatch in CSV, such as a missing quote > it will issue an error report. Gal, is this fixed downstream? I don't see those upstream PR commits in the downstream ceph-7.0-rhel-patches branch (or ceph-7.1-rhel-patches for that matter). Thomas Hi Thomas no, it is not fixed downstream. push into ceph-7.1-rhel-patches? (In reply to gal salomon from comment #4) > Hi Thomas > no, it is not fixed downstream. > > push into ceph-7.1-rhel-patches? OK, got it. It's not downstream, so that's why I moved this BZ back to POST. This BZ is targeted for 7.0 z2, so the push should happen to ceph-7.0-rhel-patches... should the BZ be re-targeted for 7.1? If we fix it in 7.0 z2, then we should have a clone BZ for 7.1, so we don't regress (7.0z2 will GA before 7.1 GA's). Thanks, Thomas the object was processed until it reached a badly-formatted row. it sent an error-message (to the client side), and the connection got broken. in radosgw-log we can observe the error-message (below). 2024-04-10T17:10:07.903+0000 7fb457d47640 10 req 9659852736619158624 42.140655518s s3:get_obj s3-select query: failed to process query; {missmatch_of_begin_end failure while csv parsing***missmatch_of_begin_end*** Line number 2 in file "csv" begin{591450} > end{64}} https://github.com/ceph/ceph/pull/56834 (fix for the broken connection) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Critical: Red Hat Ceph Storage 7.1 security, enhancements, and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:3925 |