Bug 225242
| Summary: | Merge Review: alsa-utils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Matthias Saou <matthias> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | stransky |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | matthias:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-22 15:15:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-29 20:59:59 UTC
Please find an updated spec file and a patch to the current spec file containing some suggested changes and fixes : http://thias.fedorapeople.org/merge-review/alsa-utils/ - Update License field. - Mark udev rule as config. - Use find_lang macro again to include translations (why was it removed?). Ping? It would be nice to get this package cleaned up for Fedora 8. added to rawhide. Additional cleanups : - Pick either tabs or spaces for identing, but not both. - Why is the -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 still needed? The configure script only has a "--disable-largefile" option, so I'd assume it's enabled by default. If it's still needed, a quick comment would be a good thing. - The "/var/lib/alsa" line would be clearer as "%dir /var/lib/alsa/" since nothing below it is included (only asound.state, but it's %ghost'ed). (In reply to comment #4) > Additional cleanups : > - Pick either tabs or spaces for identing, but not both. > - Why is the -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 still needed? The > configure script only has a "--disable-largefile" option, so I'd assume it's > enabled by default. If it's still needed, a quick comment would be a good thing. Aha. Unfortunately I have 64bit system so it's that always enabled there. I'll try to check it on some i386. > - The "/var/lib/alsa" line would be clearer as "%dir /var/lib/alsa/" since > nothing below it is included (only asound.state, but it's %ghost'ed). Feel free to fix it. (In reply to comment #5) > (In reply to comment #4) > > Additional cleanups : > > - Pick either tabs or spaces for identing, but not both. > > - Why is the -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 still needed? The > > configure script only has a "--disable-largefile" option, so I'd assume it's > > enabled by default. If it's still needed, a quick comment would be a good thing. > > Aha. Unfortunately I have 64bit system so it's that always enabled there. I'll > try to check it on some i386. I've compared builds for i386 and for x86_64, and configure displays this for both : checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no It's very likely that the override was needed at some point, but not any more it seems. > > - The "/var/lib/alsa" line would be clearer as "%dir /var/lib/alsa/" since > > nothing below it is included (only asound.state, but it's %ghost'ed). > > Feel free to fix it. OK, I've done that, as well as changed the indentation to be the same as alsa-lib.spec. |