Bug 2252432

Summary: darktable should unbundle LibRaw
Product: [Fedora] Fedora Reporter: Miloš Komarčević <kmilos>
Component: darktableAssignee: Germano Massullo (Thetra) <germano.massullo>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: aekoroglu, asn, germano.massullo, klember, madko, oliver, walter.pete
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-18 23:20:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Miloš Komarčević 2023-12-01 16:12:09 UTC
LibRaw 0.21.x is available since F38 (and RHEL 9?), so it can and should be unbundled by using the provided -DDONT_USE_INTERNAL_LIBRAW=ON CMake option.

Reproducible: Always

Comment 1 Miloš Komarčević 2023-12-05 18:02:22 UTC
Re your question to list here: https://www.mail-archive.com/darktable-dev@lists.darktable.org/msg06831.html

There is indeed no changes to the LibRaw source code, it is a submodule pulled directly from the LibRaw github repo: https://github.com/darktable-org/darktable/tree/master/src/external

The only changes are applied to external LibRaw-cmake scripts in order to build a static lib that can be linked, but that is bypassed by the -DDONT_USE_INTERNAL_LIBRAW=ON option.

Comment 2 Andreas Schneider 2023-12-23 10:22:43 UTC
There are no issues at all building with system libraw on Fedora >= 38.

See https://build.opensuse.org/package/show/graphics:darktable/darktable

Comment 3 Andreas Schneider 2023-12-23 10:27:07 UTC
If you're only interested in the spec file changes for it:

https://build.opensuse.org/package/rdiff/graphics:darktable/darktable?linkrev=base&rev=69

Comment 4 Germano Massullo (Thetra) 2023-12-23 11:55:45 UTC
Hello, I am discussing this with darktable developers.

Comment 5 Germano Massullo (Thetra) 2023-12-23 19:04:08 UTC
(In reply to Miloš Komarčević from comment #1)
> Re your question to list here:
> https://www.mail-archive.com/darktable-dev@lists.darktable.org/msg06831.html
> 
> There is indeed no changes to the LibRaw source code, it is a submodule
> pulled directly from the LibRaw github repo:
> https://github.com/darktable-org/darktable/tree/master/src/external
> 
> The only changes are applied to external LibRaw-cmake scripts in order to
> build a static lib that can be linked, but that is bypassed by the
> -DDONT_USE_INTERNAL_LIBRAW=ON option.

https://www.libraw.org/ -> Update policy > 
- Minor updates (0.20.1, 0.20.2…) do not change the API/ABI and new cameras are not added; generally they are just bugfixes.
- Major releases (for example, 0.20) are published once every year and a half to three years.


This means that if a new camera support is added and you just use the Fedora libraw (made of official releases), you will not get the support until next ~year and half.