Bug 225248
| Summary: | Merge Review: ant | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dbhole, pcheung |
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-21 18:11:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-29 21:01:14 UTC
New spec file and srpm at: https://pcheung.108.redhat.com/files/documents/174/375/ant.spec https://pcheung.108.redhat.com/files/documents/174/376/ant-1.6.5-4jpp.2.src.rpm Good: + Naming seems ok. + Tar ball matches with upstream. + Mock build works fine for FC6 and rawhide. Bad: - BR coreutils is not be included. - warning from rpmlint ant-manual: rpmlint of ant-manual: W: ant-manual dangling-symlink /usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5 W: ant-manual symlink-should-be-relative /usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5 W: ant-manual file-not-utf8 /usr/share/doc/ant-manual-1.6.5/manual/tutorial-tasks-filesets-properties.zip - Errors/warnings on rpmlint ant: E: ant devel-dependency java-devel W: ant non-standard-group Development/Build Tools W: ant incoherent-version-in-changelog 1.6.5-4jpp.2 0:1.6.5-4jpp.2.fc6 W: ant obsolete-not-provided ant-optional W: ant obsolete-not-provided ant-optional-full E: ant useless-explicit-provides ant (In reply to comment #2) > Good: > + Naming seems ok. > + Tar ball matches with upstream. > + Mock build works fine for FC6 and rawhide. > > Bad: > - BR coreutils is not be included. BR coreutils removed. > - warning from rpmlint ant-manual: > > rpmlint of ant-manual: > W: ant-manual dangling-symlink /usr/share/doc/ant-manual-1.6.5/manual/api > /usr/share/javadoc/ant-1.6.5 > W: ant-manual symlink-should-be-relative > /usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5 These are needed so that different versions of docs can be installed on the same machine. The symlink points to a macro, so it cannot be make relative. > W: ant-manual file-not-utf8 > /usr/share/doc/ant-manual-1.6.5/manual/tutorial-tasks-filesets-properties.zip This zip is taken directly from the source tar ball. > - Errors/warnings on rpmlint ant: > E: ant devel-dependency java-devel ant needed java-devel to run some of its tasks. > W: ant non-standard-group Development/Build Tools The group warning is OK. > W: ant incoherent-version-in-changelog 1.6.5-4jpp.2 0:1.6.5-4jpp.2.fc6 Fixed > W: ant obsolete-not-provided ant-optional > W: ant obsolete-not-provided ant-optional-full I tried adding these Provides, but then the main package conflicts with the sub-packages, so these were removed. > E: ant useless-explicit-provides ant That Provides: allows subpackages not in Fedora to be installed from JPackage. Updates srpm and spec file at the same location. God: + BR fixed. + Rpmlint was OK (with warnings) *** APPrOVED *** Please close this bug after building the package. |