Bug 2252679

Summary: xfig crashes when exporting figure to "Combined PDF/LaTeX (both parts)"
Product: [Fedora] Fedora Reporter: Daniel <daniel>
Component: xfigAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 39CC: hdegoede, itsme_410, kasal, mtasaka, steve.traylen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: xfig-3.2.9-2.fc39 xfig-3.2.9-2.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-27 01:28:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daniel 2023-12-03 21:19:02 UTC
Drawing a figure with xfig. Trying to export figure to "Combined PDF/LaTeX (both parts)". The app crashes with error message:

Warning: Missing charsets in String to FontSet conversion
*** buffer overflow detected ***: terminated

It already happened after the latest updates (think it was glibc) in F38.

Reproducible: Always

Steps to Reproduce:
1. Draw a pic with xfig
2. Try to export it with language "Combined PDF/LaTeX (both parts)"

Actual Results:  
Xfig crashes with error message:
Warning: Missing charsets in String to FontSet conversion
*** buffer overflow detected ***: terminated

Expected Results:  
3 exported files:
o the original .fig file
o a .pdf file with the same name
o a .pdf_t file with the same name

xfig - 3.2.9
transfig - 3.2.8b

Comment 1 Hans de Goede 2023-12-04 08:39:26 UTC
Thank you for your bug report. I don't really have time to look into this, so it is probably best if you report this issue upstream:

https://sourceforge.net/p/mcj/tickets/

Comment 2 Daniel 2023-12-30 22:53:59 UTC
I've recompiled transfig from transfig-3.2.9-1 src.rpm (gcc-Version 13.2.1 20231205 (Red Hat 13.2.1-6)) and installed it.
Then I took the sources from xfig-3.2.9-1 source package and compiled them (configure + make + make install). And xfig works, I can export "Combined PDF/LaTeX (both parts)".
Just recompiling the xfig-3.2.9-1 src.rpm doesn't work. The result is unfortunately as described above.
So the problem must be somewhere in the spec file of the xfig-3.2.9-1 package. I've played a little bit around with it, but couldn't figure out where the problem is.
Sorry for bothering.

Comment 3 Mamoru TASAKA 2023-12-31 15:49:33 UTC
Reproducible.

Actually, there is the upstream report https://sourceforge.net/p/mcj/tickets/165/ and
the patch provided by the upstream, i.e.

https://sourceforge.net/p/mcj/xfig/ci/68403622a6f6c7d74f73e38989cfc0ed86fb83fc/

should fix this issue.

Comment 4 Mamoru TASAKA 2023-12-31 15:51:19 UTC
For record:

*** buffer overflow detected ***: terminated

Program received signal SIGABRT, Aborted.
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44	      return INTERNAL_SYSCALL_ERROR_P (ret) ? INTERNAL_SYSCALL_ERRNO (ret) : 0;
Missing separate debuginfos, use: dnf debuginfo-install Xaw3d-1.6.4-3.fc39.x86_64 bzip2-libs-1.0.8-16.fc39.x86_64 fontconfig-2.14.2-5.fc39.x86_64 freetype-2.13.1-2.fc39.x86_64 graphite2-1.3.14-12.fc39.x86_64 harfbuzz-8.2.1-2.fc39.x86_64 libICE-1.0.10-11.fc39.x86_64 libSM-1.2.3-13.fc39.x86_64 libXau-1.0.11-3.fc39.x86_64 libXcursor-1.2.1-4.fc39.x86_64 libXext-1.3.5-3.fc39.x86_64 libXfixes-6.0.0-6.fc39.x86_64 libXft-2.3.8-3.fc39.x86_64 libXpm-3.5.17-1.fc39.x86_64 libXrender-0.9.11-3.fc39.x86_64 libXt-1.2.1-5.fc39.x86_64 libbrotli-1.1.0-1.fc39.x86_64 libjpeg-turbo-2.1.4-3.fc39.x86_64 libpng-1.6.37-15.fc39.x86_64 libuuid-2.39.2-1.fc39.x86_64 libxcb-1.13.1-12.fc39.x86_64 pcre2-10.42-1.fc39.2.x86_64 xz-libs-5.4.4-1.fc39.x86_64 zlib-1.2.13-4.fc39.x86_64
(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007ffff7a208a3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007ffff79ce8ee in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007ffff79b68ff in __GI_abort () at abort.c:79
#4  0x00007ffff79b77d0 in __libc_message (fmt=fmt@entry=0x7ffff7b34309 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
#5  0x00007ffff7ab3d19 in __GI___fortify_fail (msg=msg@entry=0x7ffff7b342f0 "buffer overflow detected") at fortify_fail.c:24
#6  0x00007ffff7ab36d4 in __GI___chk_fail () at chk_fail.c:28
#7  0x00005555555d766c in strcpy (__src=0x555555645596 "_t", __dest=0x5555557816fa "") at /usr/include/bits/string_fortified.h:79
#8  print_export (file=0x555555746080 <default_export_file> "test.pstex", xoff=<optimized out>, yoff=<optimized out>, backgrnd=<optimized out>, transparent=<optimized out>, 
    use_transp_backg=<optimized out>, border=0, grid=0x7fffffffc800 "") at /usr/src/debug/xfig-3.2.9-1.fc39.x86_64/src/u_print.c:551
#9  0x00005555555fa074 in do_export (w=<optimized out>) at /usr/src/debug/xfig-3.2.9-1.fc39.x86_64/src/w_export.c:365
#10 0x00007ffff7ee2bab in XtDispatchEventToWidget () from /lib64/libXt.so.6
#11 0x00007ffff7eeb2d2 in _XtDefaultDispatcher () from /lib64/libXt.so.6
#12 0x00007ffff7ee31b9 in XtDispatchEvent () from /lib64/libXt.so.6
#13 0x00005555555723f0 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/xfig-3.2.9-1.fc39.x86_64/src/main.c:1586

Comment 5 Mamoru TASAKA 2024-01-16 14:43:27 UTC
Hans, would you take a look at bug 2252679 comment 3 ? If you are busy, I can apply the upstream patch and push to Fedora repository.

Comment 6 Hans de Goede 2024-01-16 15:44:56 UTC
(In reply to Mamoru TASAKA from comment #5)
> Hans, would you take a look at bug 2252679 comment 3 ? If you are busy, I
> can apply the upstream patch and push to Fedora repository.

Thanks, yes if you can take care of this that would be great. I got an email from upstream with a list of bugfixes which upstream advises to apply. I'll forward it to you.

Also I would very much welcome a co-maintainer for xfig. If you're interested please let me know your FAS username and I'll add you as a co-admin.

Comment 7 Mamoru TASAKA 2024-01-17 07:17:54 UTC
Okay, thank you for reply, Hans. Once reassigning to me for this bug.

Comment 8 Fedora Update System 2024-01-18 08:18:35 UTC
FEDORA-2024-0bad3aa93c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bad3aa93c

Comment 9 Fedora Update System 2024-01-18 08:18:47 UTC
FEDORA-2024-5ca70f388d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ca70f388d

Comment 10 Hans de Goede 2024-01-18 13:22:04 UTC
mtasaka, thank you for taking care of this.

I take it that you are not interested in becoming a co-maintainer ?

Comment 11 Fedora Update System 2024-01-19 03:33:25 UTC
FEDORA-2024-5ca70f388d has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5ca70f388d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5ca70f388d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Mamoru TASAKA 2024-01-19 07:48:11 UTC
(In reply to Hans de Goede from comment #10)
> mtasaka, thank you for taking care of this.
> 
> I take it that you are not interested in becoming a co-maintainer ?

Currently I am not so interested, sorry.

Comment 13 Fedora Update System 2024-01-19 18:03:34 UTC
FEDORA-2024-0bad3aa93c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bad3aa93c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bad3aa93c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-01-27 01:28:38 UTC
FEDORA-2024-0bad3aa93c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-01-27 02:11:58 UTC
FEDORA-2024-5ca70f388d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.