Bug 225283

Summary: Merge Review: aspell-sl
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: varekova
Target Milestone: ---Flags: panemade: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-11 03:32:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-29 21:06:09 UTC
Fedora Merge Review: aspell-sl

http://cvs.fedora.redhat.com/viewcvs/devel/aspell-sl/

Comment 1 Parag AN(पराग) 2007-03-27 10:56:52 UTC
Can you update SPEC of this package similar to one that I have attached for
Review Request https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225266?

Comment 2 Parag AN(पराग) 2007-03-28 09:45:02 UTC
Also, Change Buildroot and add disttag(its optional)

Comment 3 Parag AN(पराग) 2007-03-28 10:19:29 UTC
Also found,
W: aspell-sl summary-ended-with-dot Slovenian dictionaries for Aspell.
Summary ends with a dot.


Comment 4 Parag AN(पराग) 2007-03-30 11:11:18 UTC
Review:
+ package builds in mock (development i386).
- rpmlint is NOT silent for SRPM and RPM.
  But following messages are ignorable
  E: aspell-sl no-binary
  E: aspell-sl only-non-binary-in-usr-lib
  E: aspell-sl configure-without-libdir-spec
+ SPEC file contains explanation about above warnings.
+ source files match upstream.
c4c11402bc834d796d1b56e711470480  aspell-sl-0.50-0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Requires: aspell >= 12:0.60
+ Provides: aspell-sl = 50:0.50-2.fc7
+ Not a GUI APP.

APPROVED.

Comment 5 Parag AN(पराग) 2007-04-11 03:32:13 UTC
As build is available now, therefore CLOSING this review.