Bug 2253031
| Summary: | Review Request: python-torchdata - A PyTorch module for data loading | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Rix <trix> | ||||||
| Component: | Package Review | Assignee: | Tim Flink <tflink> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | package-review, tflink | ||||||
| Target Milestone: | --- | Flags: | tflink:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/pytorch/data | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-12-16 16:46:12 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1011110 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tom Rix
2023-12-05 17:53:06 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6726866 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253031-python-torchdata/fedora-rawhide-x86_64/06726866-python-torchdata/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good overall but two minor things:
%{python3_sitelib}/torchdata is listed twice - once by the script that you have detecting the python modules and once by direct declaration. only one is needed
is there a reason that the tests aren't being run in %check? if so, can you add a comment to that effect in the specfile?
Spec URL: https://trix.fedorapeople.org/python-torchdata.spec SRPM URL: https://trix.fedorapeople.org/python-torchdata-0.7.0-2.fc40.src.rpm The listed twice is a warning, not an error, is caused by the %dir declarations. I have commented on why no check, it depends on expecttest https://github.com/ezyang/expecttest That looks like it is a low value to package. However if you will take the review of expecttest, I will add it. Created attachment 2003352 [details]
The .spec file difference from Copr build 6726866 to 6735570
Copr build: https://copr.fedorainfracloud.org/coprs/build/6735570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253031-python-torchdata/fedora-rawhide-x86_64/06735570-python-torchdata/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Tom Rix from comment #3) > Spec URL: https://trix.fedorapeople.org/python-torchdata.spec > SRPM URL: https://trix.fedorapeople.org/python-torchdata-0.7.0-2.fc40.src.rpm > > The listed twice is a warning, not an error, is caused by the %dir > declarations. > > I have commented on why no check, it depends on expecttest > https://github.com/ezyang/expecttest > That looks like it is a low value to package. > > However if you will take the review of expecttest, I will add it. Looking at expecttest, I agree that it's probably not worth packaging. The concept is interesting but according to libraries.io [1], it's only used by 2 packages on pypi. For the listed twice thing, I get that it's a warning but is there a reason for it to be listed twice? I would have thought that the sitelib dir would be found by echo+find+sed or by listing the sitelib dir and egg file manually. Why do it twice? [1] https://libraries.io/pypi/expecttest Spec URL: https://trix.fedorapeople.org/python-torchdata.spec SRPM URL: https://trix.fedorapeople.org/python-torchdata-0.7.0-3.fc40.src.rpm I removed the generated %dir's, this clears the warning Created attachment 2004364 [details]
The .spec file difference from Copr build 6735570 to 6758491
Copr build: https://copr.fedorainfracloud.org/coprs/build/6758491 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253031-python-torchdata/fedora-rawhide-x86_64/06758491-python-torchdata/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. LGTM The Pagure repository was created at https://src.fedoraproject.org/rpms/python-torchdata |