Bug 2253352

Summary:	Enable subvolume[group] snap-schedule support
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Greg Farnum <gfarnum>
Component:	CephFS	Assignee:	Milind Changire <mchangir>
Status:	CLOSED DUPLICATE	QA Contact:	sumr
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	amk, ceph-eng-bugs, cephqe-warriors, hyelloji, mchangir, ngangadh, sumr, tserlin, vshankar
Target Milestone:	---
Target Release:	7.0z2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Release Note
Doc Text:	This effort adds support to help users schedule snapshots for subvolumes in default as well as non-default subvolume groups.	Story Points:	---
Clone Of:	2253351	Environment:
Last Closed:	2024-03-29 12:16:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2243783, 2245085, 2253351
Bug Blocks:

Description Greg Farnum 2023-12-06 21:33:51 UTC

+++ This bug was initially created as a clone of Bug #2253351 +++

+++ This bug was initially created as a clone of Bug #2245085 +++

Description of problem:
snap-schedule creation for subvolume is supported, but in recent ceph build on 7.0 RHCS cluster we see an invalid argument error when option --subvol is used.

ceph fs snap-schedule add /.. 1h --fs cephfs --subvol subvolume_default_1
Invalid command: Unexpected argument '--subvol'
fs snap-schedule add <path> <snap_schedule> [<start>] [<fs>] :  Set a snapshot schedule for <path>
Error EINVAL: invalid command


Version-Release number of selected component (if applicable):


How reproducible: Consistent


Steps to Reproduce:
1.Create subvolume in default subvolumegroup
2. Enable snap-schedule. Add snap-schedule for subvolume as below,
ceph fs snap-schedule add . 1h --fs cephfs --subvol subvolume_default_1


Actual results:
snap-schedule add fails with error,
 "Invalid command: Unexpected argument '--subvol'
fs snap-schedule add <path> <snap_schedule> [<start>] [<fs>] :  Set a snapshot schedule for <path>
Error EINVAL: invalid command"

Expected results: subvol option should work.


Additional info:
ceph version 18.2.0-72.el9cp (3f281315a9c7d4bb2281729a5f3c3366ad99193d) reef (stable)

--- Additional comment from  on 2023-10-19 15:50:29 UTC ---

Additional details from offline discussion with Dev team,

this is a regression
DOWNSTREAM ONLY patches that were committed for snap-schedule for 17.x.x haven't been applied to downstream 18.2.x

Milind Changire, 5:26 PM
appropriate MR has been posted - https://gitlab.cee.redhat.com/ceph/ceph/-/merge_requests/404

--- Additional comment from  on 2023-10-31 05:12:47 UTC ---

Hi Milind, 

Can you please update the status of this bug?

Thanks,
Suma

--- Additional comment from Milind Changire on 2023-10-31 05:53:50 UTC ---

Since the downstream version of ceph is mentioned to be ceph version 18.2.0-72.el9cp (3f281315a9c7d4bb2281729a5f3c3366ad99193d) reef (stable), the support for subvolume snapshots has been removed upstream. Since the downstream bits are now a rebase to the upstream version of reef, the feature is not available downstream.

However, effort (via https://tracker.ceph.com/issues/62892) for restoring subvolume level snapshot scheduling for all subvolume groups is in progress.

You may see a backport of this feature in a z-stream release soon.

Comment 4 Venky Shankar 2024-03-29 12:16:36 UTC


*** This bug has been marked as a duplicate of bug 2245085 ***

Comment 5 Amarnath 2024-04-16 05:37:22 UTC

Hi Venky

Do we need to add Doc text for this BZ

Regards,
Amarnath