Bug 2253490
| Summary: | Review Request: akonadi-server - PIM Storage Service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://invent.kde.org/frameworks/akonadi | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-12-07 21:40:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Steve Cossette
2023-12-07 16:30:45 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6731988 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253490-akonadi-server/fedora-rawhide-x86_64/06731988-akonadi-server/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Spec review: > # trim changelog included in binary rpms > %global _changelog_trimtime %(date +%s -d "1 year ago") This can be dropped. We have a global setting in redhat-rpm-config now. > %global mysql mysql > %if 0%{?rhel} > 6 > # el7 mariadb pkgs don't have compat Provides: mysql (apparently?) > %global mysql mariadb > %endif This can be dropped and we can just depend on mysql directly. > Conflicts: akonadi < 1.13.0-100 > > # translations moved here > Conflicts: kde-l10n < 17.03 > > # when kf5-akonadi was split, -socialutils was dropped > Obsoletes: kf5-akonadi-socialutils < 16.07 This can be dropped. > Obsoletes: kf5-akonadi-devel < 16.03 > # when kf5-akonadi was split, -socialutils was dropped > Obsoletes: kf5-akonadi-socialutils-devel < 16.07 This can be dropped. > # at least dbus-1/interfaces conflict, maybe more -- rex > Conflicts: akonadi-devel We also need a "Conflicts: kf5-akonadi-server-devel" here. > # upgrade path > Obsoletes: akonadi < 1.7.90-2 > Obsoletes: akonadi-mysql < 15.08.0 This can be dropped. > %if "%{?mysql}" != "mariadb" && 0%{?fedora} > 20 > Recommends: mariadb-server > %endif This can be dropped. We'll depend on "mysql-server". Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.01.80-1.fc39.src.rpm Updated with requested spec changes Created attachment 2003141 [details]
The .spec file difference from Copr build 6731988 to 6732193
Copr build: https://copr.fedorainfracloud.org/coprs/build/6732193 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253490-akonadi-server/fedora-rawhide-x86_64/06732193-akonadi-server/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.01.80-1.fc39.src.rpm Updated Created attachment 2003144 [details]
The .spec file difference from Copr build 6732193 to 6732237
Copr build: https://copr.fedorainfracloud.org/coprs/build/6732237 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253490-akonadi-server/fedora-rawhide-x86_64/06732237-akonadi-server/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New scratch build link: https://koji.fedoraproject.org/koji/taskinfo?taskID=110023409 Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.01.80-1.fc39.src.rpm Updated devel runtime reqs Created attachment 2003152 [details]
The .spec file difference from Copr build 6732237 to 6732296
Copr build: https://copr.fedorainfracloud.org/coprs/build/6732296 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253490-akonadi-server/fedora-rawhide-x86_64/06732296-akonadi-server/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-server |