Bug 225364
| Summary: | Review Request: perl-App-CLI - Dispatcher module for command line interface programs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Burrell <ianburrell> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-02-13 21:32:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Ian Burrell
2007-01-30 05:51:31 UTC
Please remove this from your spec: Requires: perl(Locale::Maketext::Simple) It is redundant to rpm's automatic requires resultion and causes the rpm to contain a duplicate "Requires: perl(Locale::Maketext::Simple)" Remove explicit requires. Spec URL: http://znark.com/fedora/perl-App-CLI.spec SRPM URL: http://znark.com/fedora/perl-App-CLI-0.07-2.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. 8981b0628874bb7e83b00b00e58a7259 App-CLI-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: perl(App::CLI) = 0.07 perl(App::CLI::Command) perl(App::CLI::Command::Help) + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/1basic.t t/1basic....ok All tests successful. Files=1, Tests=8, 0 wallclock secs ( 0.06 cusr + 0.01 csys = 0.07 CPU) APPROVED. Built for FC-5, FC-6, devel. Package Change Request ====================== Package Name: perl-App-CLI New Branches: EL-4 EL-5 cvs done. |