Bug 2254121

Summary: [rgw][s3select]: wrong output seen for query "select cast(null as int) from s3object;"
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Hemanth Sai <hmaheswa>
Component: RGWAssignee: gal salomon <gsalomon>
Status: CLOSED ERRATA QA Contact: Hemanth Sai <hmaheswa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.0CC: akraj, ceph-eng-bugs, cephqe-warriors, gsalomon, tserlin
Target Milestone: ---   
Target Release: 7.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ceph-18.2.1-119.el9cp Doc Type: Bug Fix
Doc Text:
.SQL engine returns the correct NULL value Previously, SQL statements contained cast into type from NULL, as a result of which, the wrong result was returned instead of returning NULL. With this fix, the SQL engine identifies cast from NULL and returns NULL.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-13 14:18:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hemanth Sai 2023-12-12 04:23:14 UTC 
Description of problem:
wrong output seen while casting null to int and bool, it is returning 0 and false, as per the conversation from Gal, it should return null only

[cephuser@extensa022 ~]$ venv/bin/aws s3api --endpoint-url http://extensa027.ceph.redhat.com:80 select-object-content  --bucket bkt1 --key polarion_data.csv --expression-type 'SQL' --input-serialization '{"CSV": {"FieldDelimiter": "," , "QuoteCharacter": "\"" , "RecordDelimiter" : "\n" , "QuoteEscapeCharacter" : "\\" , "FileHeaderInfo": "USE" }, "CompressionType": "NONE"}' --output-serialization '{"CSV": {}}' --expression "select cast(null as int) from s3object;" /dev/stdout
0
0
0
0
0
0
0
0
[cephuser@extensa022 ~]$
[cephuser@extensa022 ~]$ venv/bin/aws s3api --endpoint-url http://extensa027.ceph.redhat.com:80 select-object-content  --bucket bkt1 --key polarion_data.csv --expression-type 'SQL' --input-serialization '{"CSV": {"FieldDelimiter": "," , "QuoteCharacter": "\"" , "RecordDelimiter" : "\n" , "QuoteEscapeCharacter" : "\\" , "FileHeaderInfo": "USE" }, "CompressionType": "NONE"}' --output-serialization '{"CSV": {}}' --expression "select cast(null as bool) from s3object;" /dev/stdout
false
false
false
false
false
false
false
false
[cephuser@extensa022 ~]$

Version-Release number of selected component (if applicable):
ceph version 18.2.0-128.el9cp

How reproducible:
always

Steps to Reproduce:
1.deploy rhcs7.0 cluster with rgw daemon
2.upload an s3select object
3.execute the above queries, it should return null only

Actual results:
casting null to different data types is not returning null

Expected results:
casting null to different data types should return null

Additional info:
Comment 1 gal salomon 2024-03-21 13:25:13 UTC 
https://github.com/ceph/ceph/pull/55183
Comment 2 tserlin 2024-04-02 20:23:27 UTC 
(In reply to gal salomon from comment #1)
> https://github.com/ceph/ceph/pull/55183

Gal, just getting confirmation that we're awaiting downstream cherry-picks to ceph-7.1-rhel-patches for this BZ? Including a submodule update like you did in the ceph-7.0-rhel-patches branch (for the 7.0 z2 release)?

https://gitlab.cee.redhat.com/ceph/ceph/-/commit/ec3742261bb1223dfe96f8658ea66814ae2f2113#fb32792b6e3b62f26d90c2a52c3d1392f67f82ea_2_1

Thanks,

Thomas
Comment 3 gal salomon 2024-04-03 05:08:06 UTC 
(In reply to tserlin from comment #2)
> (In reply to gal salomon from comment #1)
> > https://github.com/ceph/ceph/pull/55183
> 
> Gal, just getting confirmation that we're awaiting downstream cherry-picks
> to ceph-7.1-rhel-patches for this BZ? Including a submodule update like you
> did in the ceph-7.0-rhel-patches branch (for the 7.0 z2 release)?
> 
> https://gitlab.cee.redhat.com/ceph/ceph/-/commit/
> ec3742261bb1223dfe96f8658ea66814ae2f2113#fb32792b6e3b62f26d90c2a52c3d1392f67f
> 82ea_2_1
> 
> Thanks,
> 
> Thomas

Hi Thomas, 
yes, that is correct.
the cherry-picks to ceph-7.1-rhel-patches will be done.
Gal.
Comment 7 errata-xmlrpc 2024-06-13 14:18:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Critical: Red Hat Ceph Storage 7.1 security, enhancements, and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:3925