Bug 2254205

Summary: Review Request: libgravatar - Gravatar support library
Product: [Fedora] Fedora Reporter: Steve Cossette <farchord>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ales.astone, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://invent.kde.org/pim/%{name}
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-13 13:15:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 6745322 to 6745900 none

Description Steve Cossette 2023-12-12 16:27:55 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/libgravatar/libgravatar.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/libgravatar/libgravatar-24.01.80-1.fc39.src.rpm

Description:
Gravatar support library.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110240843

Fedora Account System Username: farchord

Comment 1 Fedora Review Service 2023-12-12 16:32:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6745322
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254205-libgravatar/fedora-rawhide-x86_64/06745322-libgravatar/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Alessandro Astone 2023-12-12 16:55:49 UTC
> BuildRequires:  cmake(Qt5Widgets)
> BuildRequires:  cmake(Qt5Network)

Qt5?

Comment 3 Steve Cossette 2023-12-12 17:33:40 UTC
(In reply to Alessandro Astone from comment #2)
> > BuildRequires:  cmake(Qt5Widgets)
> > BuildRequires:  cmake(Qt5Network)
> 
> Qt5?

Woops. Ill fix that after dinner and update.

Comment 5 Fedora Review Service 2023-12-12 18:13:25 UTC
Created attachment 2003996 [details]
The .spec file difference from Copr build 6745322 to 6745900

Comment 6 Fedora Review Service 2023-12-12 18:13:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6745900
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254205-libgravatar/fedora-rawhide-x86_64/06745900-libgravatar/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2023-12-13 13:00:01 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 8 Steve Cossette 2023-12-13 13:06:26 UTC
Thank you for the review, Neal

Comment 9 Fedora Admin user for bugzilla script actions 2023-12-13 13:06:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libgravatar