Bug 2254339

Summary: perl-Coro-Multicore: Use of incompatible pointer type in perlmulticore.h
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: perl-Coro-MulticoreAssignee: Florian Weimer <fweimer>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fweimer, perl-devel, ppisar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Coro-Multicore-1.07-9.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-15 07:45:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    

Description Paul Howarth 2023-12-13 12:02:10 UTC 
When building perl-Compress-LZF using an instrumented gcc to find issues that will affect GCC 14 (see https://fedoraproject.org/wiki/Toolchain/PortingToModernC#Special_COPR_repository_with_instrumented_GCC), I got this error:

In file included from LZF.xs:5:
/usr/include/perlmulticore.h:195:8: error: initialization of ‘void (*)(PerlInterpreter *)’ {aka ‘void (*)(struct interpreter *)’} from incompatible pointer type ‘void (*)(void)’
  195 |    = { perl_multicore_init, 0 };
      |        ^~~~~~~~~~~~~~~~~~~

The relevant part of perlmulticore.h is this:

--------------------------------------------------------------------------
/* this struct is shared between all modules, and currently */
/* contain only the two function pointers for release/acquire */
struct perl_multicore_api
{
  void (*pmapi_release)(pTHX);
  void (*pmapi_acquire)(pTHX);
};

static void perl_multicore_init (void);

static const struct perl_multicore_api perl_multicore_api_init
   = { perl_multicore_init, 0 };
--------------------------------------------------------------------------

The parameter mismatch seems to have been introduced in the downstream patch Coro-Multicore-1.04-Fix-passing-context.patch.

The same issue shows up when building perl-Coro-Multicore itself using the COPR version of gcc.

Reproducible: Always

Steps to Reproduce:
Try to build perl-Coro-Multicore using the mock configuration shown at https://fedoraproject.org/wiki/Toolchain/PortingToModernC#Special_COPR_repository_with_instrumented_GCC
Comment 1 Florian Weimer 2023-12-15 07:26:44 UTC 
(In reply to Paul Howarth from comment #0)
> The parameter mismatch seems to have been introduced in the downstream patch
> Coro-Multicore-1.04-Fix-passing-context.patch.

Thanks, flagging this as a no-upstream bug. I've got a patch that fixes this, I think.