Bug 2254736

Summary: Review Request: kaffeine - KDE media player based on VLC
Product: [Fedora] Fedora Reporter: Yaakov Selkowitz <yselkowi>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review, rc040203
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://apps.kde.org/kaffeine/
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-28 00:53:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2254460    
Bug Blocks: 2218117    

Description Yaakov Selkowitz 2023-12-15 16:35:44 UTC
Spec URL: https://yselkowitz.fedorapeople.org/kaffeine.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kaffeine-2.0.18-10.fc40.src.rpm
Description: Kaffeine is a KDE media player. Kaffeine has user-friendly interface, so that even first time users can start immediately playing their movies from DVD (including DVD menus, titles, chapters, etc.), VCD, or a file.
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2023-12-15 16:38:43 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760545
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254736-kaffeine/fedora-rawhide-x86_64/06760545-kaffeine/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Yaakov Selkowitz 2023-12-15 16:49:26 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2023-12-15 16:52:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760562
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254736-kaffeine/fedora-rawhide-x86_64/06760562-kaffeine/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Yaakov Selkowitz 2023-12-15 17:07:02 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110385701

Comment 5 Neal Gompa 2023-12-15 17:12:35 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Extra note:

> Recommends:    (vlc-plugin-pulseaudio%{?_isa} or vlc-plugin-pipewire%{?_isa})

I'd flip the order to prefer the pipewire plugin, not that it matters *too* much.

Other than that, this is good, so...

PACKAGE APPROVED.

Comment 6 Fedora Update System 2023-12-19 04:20:23 UTC
FEDORA-2023-2311255508 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2311255508

Comment 7 Fedora Update System 2023-12-19 04:20:55 UTC
FEDORA-2023-4da8f7f5ac has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da8f7f5ac

Comment 8 Fedora Update System 2023-12-20 01:07:57 UTC
FEDORA-2023-4da8f7f5ac has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4da8f7f5ac \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da8f7f5ac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-12-20 01:28:06 UTC
FEDORA-2023-2311255508 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2311255508 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2311255508

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Ralf Corsepius 2023-12-25 11:42:46 UTC
This version crashes for me, when trying view/record a hd-TV-Channel.

...
[h264 @ 0x7f9cfc09f880] mmco: unref short failure
[h264 @ 0x7f9cfc09f880] number of reference frames (0+5) exceeds max (4; probably corrupt input), discarding one
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: VideoSurface::GetBitsYCbCrImpl(): not implemented conversion VA FOURCC @@@@ -> VDP_YCBCR_FORMAT_YV12
[00007f9cd8030360] vdpau_chroma filter error: video surface export failure: VDP_STATUS_INVALID_Y_CB_CR_FORMAT
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
libvdpau-va-gl: Decoder::Render_h264(): no surfaces left in buffer
...

For me, the last functional version was rpmfusion's kaffeine + rpmfusion's vlc.

Any combo of RHAT's vlc + kaffeine appears just plain broken.

Comment 11 Fedora Update System 2023-12-28 00:53:09 UTC
FEDORA-2023-4da8f7f5ac has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-12-29 01:13:13 UTC
FEDORA-2023-2311255508 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.