Bug 2254743

Summary: Review Request: rust-psl - Extract root domain and suffix from a domain name
Product: [Fedora] Fedora Reporter: Albert Larsan <albertlarsan>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/psl
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-18 18:00:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Albert Larsan 2023-12-15 17:45:16 UTC
Spec URL: https://albertlarsan.fr/fedpkgs/rust-psl/rust-psl.spec
SRPM URL: https://albertlarsan.fr/fedpkgs/rust-psl/rust-psl-2.1.13-1.fc40.src.rpm
Description: Extract root domain and suffix from a domain name
Fedora Account System Username: albertlarsan68

Dependency for rust-addr, depencency of rust-adblock.

Comment 1 Fedora Review Service 2023-12-15 17:51:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760611
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254743-rust-psl/fedora-rawhide-x86_64/06760611-rust-psl/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-01-08 04:48:45 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is NOT packaged => 2.1.14 is now out, please update when importing
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Review Service 2024-01-08 04:50:02 UTC
Hello @albertlarsan68,
since this is your first Fedora package, you need to get sponsored by a package
sponsor before it can be accepted.

A sponsor is an experienced package maintainer who will guide you through
the processes that you will follow and the tools that you will use as a future
maintainer. A sponsor will also be there to answer your questions related to
packaging.

You can find all active sponsors here:
https://docs.pagure.org/fedora-sponsors/

I created a sponsorship request for you:
https://pagure.io/packager-sponsors/issue/614
Please take a look and make sure the information is correct.

Thank you, and best of luck on your packaging journey.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-18 17:36:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-psl

Comment 5 Fedora Update System 2024-01-18 17:58:18 UTC
FEDORA-2024-76de234d43 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-76de234d43

Comment 6 Fedora Update System 2024-01-18 18:00:26 UTC
FEDORA-2024-76de234d43 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.