Bug 2254917

Summary: Review Request: perl-IO-Async-SSL - Use SSL/TLS with IO::Async
Product: [Fedora] Fedora Reporter: Chris Adams <linux>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-03-22 01:15:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2254931, 2254932    

Description Chris Adams 2023-12-17 22:39:28 UTC
Spec URL: https://cmadams.fedorapeople.org/perl-IO-Async-SSL/perl-IO-Async-SSL.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-IO-Async-SSL/perl-IO-Async-SSL-0.25-1.fc39.src.rpm
Description:
This module extends existing IO::Async classes with extra methods to allow
the use of SSL or TLS-based connections using IO::Socket::SSL. It does not
directly provide any methods or functions of its own.

Fedora Account System Username: cmadams

Comment 4 Petr Pisar 2024-03-13 10:58:04 UTC
URL and Source0 addresses are usable. Ok.
TODO: Remove the trailing slash from URL.

Source0 archive (SHA-512: 1f9fb9442d4d4539efb4c35df8a2e6bc87543a05325d16c3efa57a63ef0d4a15c058ef93439095b2ff5d8c370f1d6500c3d109457cc23c110a2e0c08739e59eb) is original. Ok.
Summary verified from lib/IO/Async/SSL.pm. Ok.
Description verified from lib/IO/Async/SSL.pm. Ok.
License verified from Build.PL, LICENSE, lib/IO/Async/SSL.pm, lib/IO/Async/SSLStream.pm. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-IO-Async-SSL.spec ../SRPMS/perl-IO-Async-SSL-0.25-4.fc41.src.rpm ../RPMS/noarch/perl-IO-Async-SSL-0.25-4.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-IO-Async-SSL-0.25-4.fc41.noarch.rpm
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/doc/perl-IO-Async-SSL
-rw-r--r--    1 root     root                     4990 Aug 16  2023 /usr/share/doc/perl-IO-Async-SSL/Changes
-rw-r--r--    1 root     root                     6460 Aug 16  2023 /usr/share/doc/perl-IO-Async-SSL/README
drwxr-xr-x    2 root     root                        0 Aug 16  2023 /usr/share/doc/perl-IO-Async-SSL/examples
-rw-r--r--    1 root     root                     2634 Aug 16  2023 /usr/share/doc/perl-IO-Async-SSL/examples/delayed_sclient.pl
-rw-r--r--    1 root     root                     1893 Aug 16  2023 /usr/share/doc/perl-IO-Async-SSL/examples/sclient.pl
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/licenses/perl-IO-Async-SSL
-rw-r--r--    1 root     root                    18413 Aug 16  2023 /usr/share/licenses/perl-IO-Async-SSL/LICENSE
-rw-r--r--    1 root     root                     3070 Mar  8 01:00 /usr/share/man/man3/IO::Async::SSL.3pm.gz
-rw-r--r--    1 root     root                     1429 Mar  8 01:00 /usr/share/man/man3/IO::Async::SSLStream.3pm.gz
-rw-r--r--    1 root     root                    15270 Mar  8 01:00 /usr/share/perl5/vendor_perl/IO/Async/SSL.pm
-rw-r--r--    1 root     root                     1741 Mar  8 01:00 /usr/share/perl5/vendor_perl/IO/Async/SSLStream.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-IO-Async-SSL-0.25-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(:VERSION) >= 5.14.0
      1 perl(base)
      1 perl(Carp)
      1 perl(Future) >= 0.33
      1 perl(IO::Async::Handle) >= 0.29
      1 perl(IO::Async::Loop) >= 0.61
      1 perl(IO::Async::SSL)
      1 perl(IO::Async::Stream)
      1 perl(IO::Socket::SSL) >= 2.003
      1 perl(POSIX)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Change "perl(IO::Async::Loop)" minimal version 0.61 to 0.66 (Build.PL:13).

$ rpm -q --provides -p ../RPMS/noarch/perl-IO-Async-SSL-0.25-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(IO::Async::SSL) = 0.25
      1 perl(IO::Async::SSLStream) = 0.25
      1 perl-IO-Async-SSL = 0.25-4.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-IO-Async-SSL-0.25-4.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 <https://koji.fedoraproject.org/koji/taskinfo?taskID=114886522>. Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
The package is APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-03-13 15:25:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IO-Async-SSL

Comment 6 Fedora Update System 2024-03-13 15:53:34 UTC
FEDORA-2024-228777e062 (perl-IO-Async-SSL-0.25-4.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-228777e062

Comment 7 Fedora Update System 2024-03-13 15:59:50 UTC
FEDORA-2024-29d1c91a56 (perl-IO-Async-SSL-0.25-4.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-29d1c91a56

Comment 8 Fedora Update System 2024-03-14 01:04:28 UTC
FEDORA-2024-29d1c91a56 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-29d1c91a56 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-29d1c91a56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-03-14 01:59:09 UTC
FEDORA-2024-228777e062 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-228777e062 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-228777e062

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-03-22 01:15:23 UTC
FEDORA-2024-228777e062 (perl-IO-Async-SSL-0.25-4.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-03-23 00:36:13 UTC
FEDORA-2024-29d1c91a56 (perl-IO-Async-SSL-0.25-4.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.