Bug 2254923

Bumped release for spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Test-HTTP-LocalServer/perl-Test-HTTP-LocalServer.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Test-HTTP-LocalServer/perl-Test-HTTP-LocalServer-0.75-2.fc39.src.rpm

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires
     perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13
     perl(vars) - lib/Test/HTTP/LocalServer.pm:433
     perl(warnings) - t/00-load.t:4

$ rpm -qp --requires perl-Test-HTTP-LocalServer-0.75-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Cwd)
      1 perl(File::Basename)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(FindBin)
      1 perl(HTTP::Daemon) >= 6.05
      1 perl(HTTP::Tiny)
      1 perl-libs
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(URI::URL)
      1 perl(vars)
      1 perl(:VERSION) >= 5.8.0
Binary requires 
FIX: Please add run-requires
     perl(CGI) - lib/Test/HTTP/log-server:5
     perl(Getopt::Long) - lib/Test/HTTP/log-server:7
     perl(HTTP::Request::AsCGI) - lib/Test/HTTP/log-server:6
     perl(HTTP::Response) - used in lib/Test/HTTP/log-server
     perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13
     perl(Socket) - lib/Test/HTTP/log-server:8
     perl(URI) - lib/Test/HTTP/log-server:4

$ rpm -qp --provides perl-Test-HTTP-LocalServer-0.75-2.fc40.noarch.rpm | sort | uniq -c
      1 perl(Test::HTTP::LocalServer) = 0.75
      1 perl-Test-HTTP-LocalServer = 0.75-2.fc40
Binary provides are Ok.

$ rpmlint ./perl-Test-HTTP-LocalServer*
============================== rpmlint session starts ==============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
perl-Test-HTTP-LocalServer.noarch: E: wrong-script-end-of-line-encoding /usr/share/perl5/vendor_perl/Test/HTTP/cookie-server
perl-Test-HTTP-LocalServer.noarch: W: unexpanded-macro %description -l C %ENV
perl-Test-HTTP-LocalServer.src: W: unexpanded-macro %description -l C %ENV
perl-Test-HTTP-LocalServer.noarch: W: incoherent-version-in-changelog 0.04-2 ['0.75-2.fc40', '0.75-2']
 2 packages and 1 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 0.2 s
Rpmlint is ok

FIX: Update different version in changelog
FIX: Remove wrong script end of line encoding e.g.
     perl -pi -e 's/\r//' lib/Test/HTTP/cookie-server

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
      https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.
You can use:
  %{perl_vendorlib}/Test/HTTP*
  %{_mandir}/man3/Test::HTTP*

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

Bumped release for additional spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Test-HTTP-LocalServer/perl-Test-HTTP-LocalServer.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Test-HTTP-LocalServer/perl-Test-HTTP-LocalServer-0.75-3.fc39.src.rpm

> BuildRequires
> FIX: Please add build-requires
>      perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13
>      perl(vars) - lib/Test/HTTP/LocalServer.pm:433
>      perl(warnings) - t/00-load.t:4
Done

> Binary requires 
> FIX: Please add run-requires
>      perl(CGI) - lib/Test/HTTP/log-server:5
>      perl(Getopt::Long) - lib/Test/HTTP/log-server:7
>      perl(HTTP::Request::AsCGI) - lib/Test/HTTP/log-server:6
>      perl(HTTP::Response) - used in lib/Test/HTTP/log-server
>      perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13
>      perl(Socket) - lib/Test/HTTP/log-server:8
>      perl(URI) - lib/Test/HTTP/log-server:4
Done

> FIX: Update different version in changelog
Done

> FIX: Remove wrong script end of line encoding e.g.
>      perl -pi -e 's/\r//' lib/Test/HTTP/cookie-server
Done

The package is in line with Fedora and Perl packaging guide lines.
Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-HTTP-LocalServer

FEDORA-2024-f6ea5ea3c4 (perl-Test-HTTP-LocalServer-0.75-3.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f6ea5ea3c4

Thanks for the review! And for the additional pointers I applied to all in this pending set (and will do in the future).

FEDORA-2024-f6ea5ea3c4 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f6ea5ea3c4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f6ea5ea3c4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-f6ea5ea3c4 (perl-Test-HTTP-LocalServer-0.75-3.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.