Bug 2254930
| Summary: | Review Request: perl-AnyEvent-WebSocket-Client - WebSocket client for AnyEvent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Adams <linux> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-06-02 03:37:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2254926 | ||
| Bug Blocks: | 2254934 | ||
|
Description
Chris Adams
2023-12-17 23:01:25 UTC
Note: depends on perl-AnyEvent-Connector (review BZ 2254926) Bumped release for spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client-0.55-2.fc39.src.rpm Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client-0.55-3.fc39.src.rpm Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyEvent-WebSocket-Client-0.55-4.fc39.src.rpm URL and Source0 addresses are Ok.
Source0 archive (SHA512 4d41dd6350342c12cef9dd60ccd7faf9b008e6722057d2f21d816e9c9c989c470866a98fe9b86765deee4e432b788cd13904db6df67993aa7129894a833ee08a) is original. Ok.
Summary verified from lib/AnyEvent/WebSocket/Client.pm. Ok.
Description verified from lib/AnyEvent/WebSocket/Client.pm. Ok.
License verified from LICENSE, README, dist.ini, lib/AnyEvent/WebSocket/Client.pm, lib/AnyEvent/WebSocket/Connection.pm, lib/AnyEvent/WebSocket/Message.pm. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Build-require 'perl(PerlX::Maybe::XS)'. Since you recommend it, it is a good idea to use it when running tests which exhibit PerlX::Maybe. Otherwise, you would test code a different code path than is recommended to the users.
TODO: Rewrite 'BuildRequires: perl(Crypt::Random::Source) >= 0.08' as 'BuildConflicts: perl(Crypt::Random::Source) < 0.08'. A purpose of the dependency is to avoid warnings with too old Crypt::Random::Source (dist.ini:84).
TODO: Consider packaging ./example as a documentation.
All tests pass. Ok.
$ rpmlint perl-AnyEvent-WebSocket-Client.spec ../SRPMS/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.src.rpm ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is OK.
$ rpm -q -lv -p ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-AnyEvent-WebSocket-Client
-rw-r--r-- 1 root root 9266 May 4 2023 /usr/share/doc/perl-AnyEvent-WebSocket-Client/Changes
-rw-r--r-- 1 root root 7390 May 4 2023 /usr/share/doc/perl-AnyEvent-WebSocket-Client/README
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-AnyEvent-WebSocket-Client
-rw-r--r-- 1 root root 18359 May 4 2023 /usr/share/licenses/perl-AnyEvent-WebSocket-Client/LICENSE
-rw-r--r-- 1 root root 3896 Mar 8 01:00 /usr/share/man/man3/AnyEvent::WebSocket::Client.3pm.gz
-rw-r--r-- 1 root root 3200 Mar 8 01:00 /usr/share/man/man3/AnyEvent::WebSocket::Connection.3pm.gz
-rw-r--r-- 1 root root 1801 Mar 8 01:00 /usr/share/man/man3/AnyEvent::WebSocket::Message.3pm.gz
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/WebSocket
-rw-r--r-- 1 root root 12505 May 4 2023 /usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Client.pm
-rw-r--r-- 1 root root 13799 May 4 2023 /usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Connection.pm
-rw-r--r-- 1 root root 2606 May 4 2023 /usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Message.pm
/usr/share/perl5/vendor_perl/AnyEvent is provided by required perl-AnyEvent-Connector.
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f | uniq -c
1 perl(AE)
1 perl(AnyEvent)
1 perl(AnyEvent::Connector)
1 perl(AnyEvent::Handle)
1 perl(AnyEvent::Socket)
1 perl(AnyEvent::WebSocket::Connection)
1 perl(AnyEvent::WebSocket::Message)
1 perl(Carp)
1 perl(Encode)
1 perl(Moo)
1 perl(PerlX::Maybe)
1 perl(Protocol::WebSocket::Frame)
1 perl(Protocol::WebSocket::Handshake::Client)
1 perl(Protocol::WebSocket::Request)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(URI)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --recommends -p ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f | uniq -c
1 perl(PerlX::Maybe::XS)
Binary recommends are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f | uniq -c
1 perl(AnyEvent::WebSocket::Client) = 0.55
1 perl(AnyEvent::WebSocket::Connection) = 0.55
1 perl(AnyEvent::WebSocket::Message) = 0.55
1 perl-AnyEvent-WebSocket-Client = 0.55-4.fc41
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds on Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117740822). Ok.
The package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
Resolution: This package is APPROVED.
FEDORA-2024-c2276a4e02 (perl-AnyEvent-WebSocket-Client-0.55-5.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2276a4e02 FEDORA-2024-c2276a4e02 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2276a4e02 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2276a4e02 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-6c41bb8003 (perl-AnyEvent-WebSocket-Client-0.55-5.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6c41bb8003 FEDORA-2024-6c41bb8003 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6c41bb8003 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6c41bb8003 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-c2276a4e02 (perl-AnyEvent-WebSocket-Client-0.55-5.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-6c41bb8003 (perl-AnyEvent-WebSocket-Client-0.55-5.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |