Bug 2254979

Summary: NLopt fails to build with Python 3.13: error: ‘PyEval_CallObject’ was not declared in this scope; did you mean ‘PyObject_CallObject’?
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: NLoptAssignee: Benson Muite <benson_muite>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 41CC: benson_muite, besser82, fedora, fti-bugs, ksurma, mhroncok
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NLopt-2.8.0^202409167cdebfe-1.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-01 01:17:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2244836, 2260877    

Description Karolina Surma 2023-12-18 10:20:28 UTC
NLopt fails to build with Python 3.13.0a2.
/builddir/build/BUILD/nlopt-2.7.1/redhat-linux-build/src/swig/CMakeFiles/nlopt_python.dir/nloptPYTHON_wrap.cxx: In function ‘double func_python(unsigned int, const double*, double*, void*)’:
/builddir/build/BUILD/nlopt-2.7.1/redhat-linux-build/src/swig/CMakeFiles/nlopt_python.dir/nloptPYTHON_wrap.cxx:5103:22: error: ‘PyEval_CallObject’ was not declared in this scope; did you mean ‘PyObject_CallObject’?
 5103 |   PyObject *result = PyEval_CallObject((PyObject *) f, arglist);
      |                      ^~~~~~~~~~~~~~~~~
      |                      PyObject_CallObject
/builddir/build/BUILD/nlopt-2.7.1/redhat-linux-build/src/swig/CMakeFiles/nlopt_python.dir/nloptPYTHON_wrap.cxx: In function ‘void mfunc_python(unsigned int, double*, unsigned int, const double*, double*, void*)’:
/builddir/build/BUILD/nlopt-2.7.1/redhat-linux-build/src/swig/CMakeFiles/nlopt_python.dir/nloptPYTHON_wrap.cxx:5140:19: error: ‘PyEval_CallObject’ was not declared in this scope; did you mean ‘PyObject_CallObject’?
 5140 |   PyObject *res = PyEval_CallObject((PyObject *) f, arglist);
      |                   ^~~~~~~~~~~~~~~~~
      |                   PyObject_CallObject

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use PyObject_CallNoArgs() or PyObject_Call() instead.
Warning: PyObject_Call() positional arguments must be a tuple and must not be NULL,
keyword arguments must be a dict or NULL, whereas removed functions checked arguments type and accepted NULL positional and keyword arguments.
To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with PyObject_Call(),
pass an empty tuple as positional arguments using PyTuple_New(0).


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06766197-NLopt/

For all our attempts to build NLopt with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/NLopt/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:07:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Karolina Surma 2024-06-12 14:56:40 UTC
*** Bug 2291478 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Fails To Install 2024-06-19 19:58:05 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 4 Fedora Fails To Install 2024-07-13 07:59:36 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 5 Fedora Fails To Install 2024-08-13 00:01:55 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/NLopt by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 6 Cristian Le 2024-08-15 07:34:47 UTC
This should be an issue on swig side. Seems later swig support python3.13, but they haven't made a release for it yet, and I have bad blood with them so they would not be listening to me.

Comment 7 Miro Hrončok 2024-08-15 10:50:16 UTC
I don't think so...

$ fedpkg clone NLopt
$ cd NLopt
[NLopt (rawhide)]$ fedpkg prep
[NLopt (rawhide %)]$ cd nlopt-2.7.1
[nlopt-2.7.1 (rawhide %)]$ rg PyEval_CallObject
src/swig/nlopt-python.i
137:  PyObject *result = PyEval_CallObject((PyObject *) f, arglist);
174:  PyObject *res = PyEval_CallObject((PyObject *) f, arglist);


This needs to be corrected in src/swig/nlopt-python.i

Comment 8 Cristian Le 2024-08-15 10:53:05 UTC
Oh ok I'll open an issue for that then

Comment 9 Cristian Le 2024-08-15 20:00:40 UTC
Resolved in https://github.com/stevengj/nlopt/commit/d716820578d226976fbb4fa68478758dad1c79b0

benson_muite

Comment 10 Fedora Admin user for bugzilla script actions 2024-08-22 13:32:29 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 11 Miro Hrončok 2024-08-22 14:43:34 UTC
I'm going to assume you plan to fix it.

Comment 12 Karolina Surma 2024-09-04 14:36:39 UTC
This package has failed to build with Python 3.13 so far. Fedora 41 is already in the Beta Freeze phase. What's your plan going forward? Will the package be fixed in time for the Final Freeze of Fedora 41 (planned on Oct 15th 2024)?
If you don't plan or can't fix the package before Fedora 41 goes into the Final Freeze phase, please retire the package. You can unretire it anytime during the Fedora 41 lifecycle - doing this now will simply ensure that we don't release Fedora with a broken package. Thank you!

Comment 13 Benson Muite 2024-09-25 13:16:51 UTC
Trying with the fix at https://github.com/stevengj/nlopt/issues/565

Comment 15 Fedora Update System 2024-09-29 12:02:18 UTC
FEDORA-2024-ac73e736a3 (NLopt-2.8.0^202409167cdebfe-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ac73e736a3

Comment 16 Fedora Update System 2024-09-30 02:24:26 UTC
FEDORA-2024-ac73e736a3 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ac73e736a3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ac73e736a3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-10-01 01:17:08 UTC
FEDORA-2024-ac73e736a3 (NLopt-2.8.0^202409167cdebfe-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.