Bug 2255174

Summary:	Review Request: rust-xkeysym - Library for working with X11 keysyms
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://crates.io/crates/xkeysym
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-22 01:50:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2098370, 2251774, 2255175

Description Aleksei Bavshin 2023-12-19 02:58:07 UTC

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-xkeysym/rust-xkeysym.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-xkeysym/rust-xkeysym-0.2.0-1.fc39.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
A library for working with X11 keysyms.

Fedora Account System Username: alebastr

Comment 1 Fedora Review Service 2023-12-19 03:04:36 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6769166
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255174-rust-xkeysym/fedora-rawhide-x86_64/06769166-rust-xkeysym/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-12-20 18:52:33 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Assuming you are also working on updating x11rb to a new version (since you submitted as-raw-xcb-connection), you will need to take care to adapt this package - it currently depends on x11rb 0.11.

Comment 3 Aleksei Bavshin 2023-12-20 18:58:17 UTC

> Assuming you are also working on updating x11rb to a new version (since you
> submitted as-raw-xcb-connection), you will need to take care to adapt this
> package - it currently depends on x11rb 0.11.

Ouch. Thanks for noticing, seems like a simple version bump is enough: https://github.com/rust-windowing/xkeysym/commit/7d14bb06f55611056db792a73e66f9375df4414a

Comment 4 Fedora Admin user for bugzilla script actions 2023-12-21 03:35:23 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-xkeysym