Bug 2255180

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6769192
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255180-rust-wayland-protocols-wlr/fedora-rawhide-x86_64/06769192-rust-wayland-protocols-wlr/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This has similar problem as the plasma protocols package - it bundles wlr-protocols (unknown version).

All XML files for protocol definitions seem to have their own included license text (HPND-sell-variant or MIT, as far as I can tell).

This will need to be addressed in the package's spec file (both with bundled() Provides, and an updated license tag of the package).

Oh, and please also exclude all the files that are not necessary for building the crate, most importantly, wlr-protocols/check.sh, which causes a dependency on /bin/bash to be generated.

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-wayland-protocols-wlr/rust-wayland-protocols-wlr.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-wayland-protocols-wlr/rust-wayland-protocols-wlr-0.2.0-1.fc39.src.rpm

Thanks for the review! Updated with your comments addressed.

Created attachment 2005248 [details]
The .spec file difference from Copr build 6769192 to 6776284

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6776284
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255180-rust-wayland-protocols-wlr/fedora-rawhide-x86_64/06776284-rust-wayland-protocols-wlr/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks good to me now, thank you!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wayland-protocols-wlr

FEDORA-2023-652f5d820f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-652f5d820f

FEDORA-2023-652f5d820f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.