Bug 2255182
| Summary: | Review Request: rust-wayland-protocols-plasma - Generated API for the Plasma wayland protocol extensions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aleksei Bavshin <alebastr89> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/wayland-protocols-plasma | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-12-29 07:25:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2156605, 2156606, 2255177 | ||||||
| Bug Blocks: | 2245420 | ||||||
| Attachments: |
|
||||||
|
Description
Aleksei Bavshin
2023-12-19 03:25:45 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6769194 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255182-rust-wayland-protocols-plasma/fedora-rawhide-x86_64/06769194-rust-wayland-protocols-plasma/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Reviewed against local / COPR builds of this package's dependencies. === The project contains a bundled copy of the "plasma-wayland-protocols" project (appears to be version 1.10.0). This needs to be declared (i.e. "Provides: bundled(plasma-wayland-protocols) = 1.10.0" or something similar) in the -devel subpackage. Additionally, those protocol definitions are covered by various licenses (BSD-3-Clause, LGPL-2.1-or-later, MIT, MIT-CMU, as far as I can tell). License files for these are already included in the package, but they must be added to the license tag of the package as well. I don't think the license metadata in Cargo.toml needs to be changed, since only MIT-licensed code that is generated *from* these protocol definitions will be linked into dependent applications, but not the protocol definitions *themselves*. Spec URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-wayland-protocols-plasma/rust-wayland-protocols-plasma.spec SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty/0.13.0/rust-wayland-protocols-plasma/rust-wayland-protocols-plasma-0.2.0-1.fc39.src.rpm Thanks for the review! Fixed and reuploaded. Created attachment 2005247 [details]
The .spec file difference from Copr build 6769194 to 6776108
Copr build: https://copr.fedorainfracloud.org/coprs/build/6776108 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255182-rust-wayland-protocols-plasma/fedora-rawhide-x86_64/06776108-rust-wayland-protocols-plasma/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me now, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wayland-protocols-plasma FEDORA-2023-652f5d820f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-652f5d820f FEDORA-2023-652f5d820f has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |