Bug 2255574

Summary:	Review Request: hiprand - HIP random number generator
Product:	[Fedora] Fedora	Reporter:	Jeremy Newton <alexjnewt>
Component:	Package Review	Assignee:	Tom Rix <trix>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, trix
Target Milestone:	---	Flags:	trix: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/ROCm/%{upstreamname}
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-13 22:59:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy Newton 2023-12-22 00:58:15 UTC

Spec URL: https://mystro256.fedorapeople.org/hiprand.spec
SRPM URL: https://mystro256.fedorapeople.org/hiprand-6.0.0-1.fc40.src.rpm
Description:
hipRAND is a RAND marshalling library, with multiple supported backends. It
sits between the application and the backend RAND library, marshalling inputs
into the backend and results back to the application. hipRAND exports an
interface that does not require the client to change, regardless of the chosen
backend. Currently, hipRAND supports either rocRAND or cuRAND.
Fedora Account System Username: mystro256
Copr build: https://copr.fedorainfracloud.org/coprs/mystro256/playground/build/6782380/
Note: This is already a subpackage of rocrand, but in ROCm 6.0, upstream has separated the two components, so this is a necessary step to ship hiprand 6.0 in Fedora.

Also note that this needs https://koji.fedoraproject.org/koji/buildinfo?buildID=2336772

Comment 1 Fedora Review Service 2023-12-22 04:41:32 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6782737
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255574-hiprand/fedora-rawhide-x86_64/06782737-hiprand/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom Rix 2023-12-22 12:37:08 UTC

The build fails because I assume it needs rocrand 6.0
Do we want to add version logic to the rocm packages in BuildRequire ?
This is a for all rocm packages question.

Some minor things

%global toolchain clang

could be 
%global toolchain rocm


%bcond_with check
run some tests

could be 
%bcond_with test
create the -test subpackage

I prefer the -test subpackage because I can build on one beefy machine and copy the rpm's to a test machines that have different hw.

Comment 3 Jeremy Newton 2023-12-22 14:37:39 UTC

Thanks, see updated files:
Spec URL: https://mystro256.fedorapeople.org/hiprand.spec
SRPM URL: https://mystro256.fedorapeople.org/hiprand-6.0.0-2.fc40.src.rpm

> Do we want to add version logic to the rocm packages in BuildRequire ?
> This is a for all rocm packages question.

Yeah I've been thinking about that. I was going to wait for the llvm changes be put in place, then rehaul the build requires. A lot of them are common, so I was considering a metapackage or adding them as package requires to rocm-comgr-devel or hipcc.

Comment 4 Tom Rix 2023-12-22 16:05:58 UTC

Thanks.

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-22 16:21:32 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/hiprand