Bug 2255927

Summary: Review Request: rust-sscanf - Sscanf (inverse of format!()) Macro based on Regex
Product: [Fedora] Fedora Reporter: Jordan Rome <jordan>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-27 01:33:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jordan Rome 2023-12-26 19:10:14 UTC
Spec URL: https://jordalgo.fedorapeople.org/review/rust-sscanf/rust-sscanf.spec
SRPM URL: https://jordalgo.fedorapeople.org/review/rust-sscanf/rust-sscanf-0.4.1-1.fc40.src.rpm

Description:
A sscanf (inverse of format!()) Macro based on Regex.

Fedora Account System Username: jordalgo

Comment 1 Jordan Rome 2023-12-26 19:10:17 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110889505

Comment 2 Fedora Review Service 2023-12-26 19:10:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6818273
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255927-rust-sscanf/srpm-builds/06818273/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-12-26 20:09:38 UTC
Taking this review

Comment 4 Davide Cavalca 2023-12-26 20:13:25 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all enabled unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED. Please file an issue upstream for the failing tests, and remember to add the rust2rpm.toml you used to the package repo when importing.

Comment 5 Jordan Rome 2023-12-27 00:30:34 UTC
Issue filed here for the failing test: https://github.com/mich101mich/sscanf/issues/10

Comment 6 Fedora Admin user for bugzilla script actions 2023-12-27 00:39:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sscanf

Comment 7 Fedora Update System 2023-12-27 01:31:06 UTC
FEDORA-2023-985236d248 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-985236d248

Comment 8 Fedora Update System 2023-12-27 01:33:10 UTC
FEDORA-2023-985236d248 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.