Bug 2255947
| Summary: | Review Request: foonathan-memory - STL compatible C++ memory allocator library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||||
| Component: | Package Review | Assignee: | Tom Rix <trix> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, trix | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | trix:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/foonathan/memory | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-01-19 01:57:26 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Felix Wang
2023-12-27 01:41:10 UTC
Spec URL: https://topazus.fedorapeople.org/rpms/foonathan-memory.spec SRPM URL: https://topazus.fedorapeople.org/rpms/foonathan-memory-0.7.3-1.fc40.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/6821186 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255947-foonathan-memory/fedora-rawhide-x86_64/06821186-foonathan-memory/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/6821184 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255947-foonathan-memory/fedora-rawhide-x86_64/06821184-foonathan-memory/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://topazus.fedorapeople.org/rpms/foonathan-memory.spec SRPM URL: https://topazus.fedorapeople.org/rpms/foonathan-memory-0.7.3-1.fc40.src.rpm Created attachment 2008917 [details]
The .spec file difference from Copr build 6821186 to 6909378
Copr build: https://copr.fedorainfracloud.org/coprs/build/6909378 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255947-foonathan-memory/fedora-rawhide-x86_64/06909378-foonathan-memory/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It would be nice if the example could be added to %docdir/%{name}/
I used this to check after installing -devel
The cmake-ing worked as-is so i think the directory could be cp-ed without modification.
[ 10%] Building CXX object CMakeFiles/foonathan_memory_example_allocator_storage.dir/allocator_storage.o
/home/trix/reviews/review-foonathan-memory/upstream/memory-0.7-3/example/allocator_storage.cpp:10:10: fatal error: foonathan/memory/allocator_storage.hpp: No such file or directory
10 | #include <foonathan/memory/allocator_storage.hpp> // allocator_reference, any_allocator_reference
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/foonathan_memory_example_allocator_storage.dir/build.make:76: CMakeFiles/foonathan_memory_example_allocator_storage.dir/allocator_storage.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:91: CMakeFiles/foonathan_memory_example_allocator_storage.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
$ ls /usr/include/foonathan_memory/
foonathan
could you check the install location of the headers ?
From the example, it seems like it should be /usr/include/foonathan
Thanks for reviewing. > It would be nice if the example could be added to %docdir/%{name}/ Added -doc subpackage to store the example files in this location. > could you check the install location of the headers ? > From the example, it seems like it should be /usr/include/foonathan The install directory of headers modified here, https://github.com/foonathan/memory/pull/165. So I manually add the content of the patch to fix it. Spec URL: https://topazus.fedorapeople.org/rpms/foonathan-memory.spec SRPM URL: https://topazus.fedorapeople.org/rpms/foonathan-memory-0.7.3-1.fc40.src.rpm Created attachment 2009087 [details]
The .spec file difference from Copr build 6909378 to 6914335
Copr build: https://copr.fedorainfracloud.org/coprs/build/6914335 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255947-foonathan-memory/fedora-rawhide-x86_64/06914335-foonathan-memory/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for the changes Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/foonathan-memory FEDORA-2024-39d8f08c70 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-39d8f08c70 FEDORA-2024-39d8f08c70 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |