Bug 2256308

Summary: Review Request: golang-github-bep-godartsass2 - Go API backed by the native Dart Sass Embedded executable
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-13 23:36:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2209669, 2213666    

Description W. Michael Petullo 2023-12-31 01:35:10 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass-2-2.0.0-1.20231231git4d97c01.fc39.src.rpm
Description: Go API backed by the native Dart Sass Embedded executable
Fedora Account System Username: mikep

This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.

Comment 1 W. Michael Petullo 2023-12-31 18:45:53 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass-2.0.0-1.20231231git4d97c01.fc39.src.rpm

Rebuild with go2rpm 1.10.0. Is this the right name for the SRPM? -2.0.0, rather than -2, seems exclusive.

Comment 2 Fedora Review Service 2023-12-31 19:15:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840031
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256308-golang-github-bep-godartsass-2/srpm-builds/06840031/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-12-31 19:19:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840053
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256308-golang-github-bep-godartsass-2/fedora-rawhide-x86_64/06840053-golang-github-bep-godartsass/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 W. Michael Petullo 2024-01-02 23:01:11 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-godartsass2-2.0.0-1.fc39.src.rpm

Rebuilt with `go2rpm github.com/bep/godartsass/v2 -f https://github.com/bep/godartsass -v 2.0.0`.

Comment 5 Fedora Review Service 2024-01-02 23:03:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6850728
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256308-golang-github-bep-godartsass2/fedora-rawhide-x86_64/06850728-golang-github-bep-godartsass2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Mikel Olasagasti Uranga 2024-01-07 15:38:54 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 7 W. Michael Petullo 2024-01-13 23:17:47 UTC
I do not see the problem, but running "fedpkg request-repo golang-github-bep-godartsass2 2256308" results in the releng-bot closing the issue right away. Might this have to do with me changing the bug report name from "golang-github-bep-godartsass-2" to "golang-github-bep-godartsass2"?

Comment 8 Fedora Admin user for bugzilla script actions 2024-01-13 23:21:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-godartsass2

Comment 9 Fedora Update System 2024-01-13 23:34:29 UTC
FEDORA-2024-87e42082a7 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-87e42082a7

Comment 10 Fedora Update System 2024-01-13 23:36:26 UTC
FEDORA-2024-87e42082a7 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.