Bug 2256580

+++ This bug was initially created as a clone of Bug #2253497 +++

Description of problem (please be detailed as possible and provide log
snippests):
Applying DR Policy to app set application, the system is suggesting a label that cannot work, it should be filtered out. Only labels with appname= should be recommended

Version of all relevant components (if applicable):


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?


Is there any workaround available to the best of your knowledge?
Creating your github resource with a short label e.g. appname=kubevirt

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
2

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1. Create an app set application from here: https://github.com/kgoldbla/ocm-kubevirt-samples/blob/vm9-application/vm-standalone-pvc-odr-regional/pvc.yaml
2. selected the app:kebernetes/instance-app-set-vm-standalone-dv-odr-regional option
3. Relocating will not work with this.
4. Only the appname=<label> should be recommended
5. ...instance-of= should not be used


Actual results:
...instance-of= was recommended as an option and won't work for dr

Expected results:
On appname= should be recommended

Additional info:
See attached screenshots

--- Additional comment from RHEL Program Management on 2023-12-07 17:11:10 UTC ---

This bug having no release flag set previously, is now set with release flag 'odf‑4.15.0' to '?', and so is being proposed to be fixed at the ODF 4.15.0 release. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag.

--- Additional comment from gowtham on 2023-12-15 10:30:13 UTC ---

if only appname=<label> label is required then why do we even need UI for selecting labels? Is backend can't add it by default?

--- Additional comment from Shyamsundar on 2023-12-15 12:34:40 UTC ---

(In reply to gowtham from comment #2)
> if only appname=<label> label is required then why do we even need UI for
> selecting labels? Is backend can't add it by default?

The initial report in the BZ suggests this. In practice a deployed workload may choose ANY label to group/identify their PVCs. We cannot only provide appName label as the choice here.

The problem was that we displayed and allowed the selection of a well known bad label that is auto generate (i.e the "instance" label). I would "fix" this by removing that label and any others that we deem are such bad examples from [1] from the list that we display and not restrict it to just the appName label.

[1] https://kubernetes.io/docs/reference/labels-annotations-taints/#labels-annotations-and-taints-used-on-api-objects