Bug 2256736

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6860547
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256736-perl-meta/fedora-rawhide-x86_64/06860547-perl-meta/fedora-review/review.txt

Found issues:

- Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I rebased the package the latest upstream version:

Spec URL: https://ppisar.fedorapeople.org/perl-meta/perl-meta.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-meta/perl-meta-0.004-1.fc40.src.rpm

Created attachment 2014027 [details]
The .spec file difference from Copr build 6860547 to 6973246

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6973246
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256736-perl-meta/fedora-rawhide-x86_64/06973246-perl-meta/fedora-review/review.txt

Found issues:

- Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-meta-0.004-1.fc40.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 perl-libs
      1 perl(:MODULE_COMPAT_5.38.2)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-meta-0.004-1.fc40.x86_64.rpm | sort | uniq -c
      1 perl(meta) = 0.004
      1 perl-meta = 0.004-1.fc40
      1 perl-meta(x86-64) = 0.004-1.fc40
Binary provides are Ok.

$ rpmlint ./perl-meta*
==================================== rpmlint session starts ===================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4
perl-meta.x86_64: E: shared-library-without-dependency-information /usr/lib64/perl5/vendor_perl/auto/meta/meta.so
perl-meta-tests.noarch: W: no-documentation
===== 3 packages and 1 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.3 s ====
Rpmlint is ok

TODO: Please consider to use macro style %{optflags} for optimization flags
      as for build root.

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-meta

Thanks for the review. I replaced the variable with the macro.

FEDORA-2024-513c1d2a8a (perl-meta-0.004-1.fc39, perl-Syntax-Operator-Divides-0.07-1.fc39, and 2 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-513c1d2a8a

FEDORA-2024-c4d455ce90 (perl-meta-0.004-1.fc38, perl-Syntax-Operator-Divides-0.07-1.fc38, and 2 more) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c4d455ce90

FEDORA-2024-513c1d2a8a has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-513c1d2a8a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-513c1d2a8a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-c4d455ce90 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c4d455ce90`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c4d455ce90

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-513c1d2a8a (perl-meta-0.004-1.fc39, perl-Syntax-Operator-Divides-0.07-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-c4d455ce90 (perl-meta-0.004-1.fc38, perl-Syntax-Operator-Divides-0.07-1.fc38, and 2 more) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.