Bug 225692
| Summary: | Merge Review: dhcpv6 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Chris Lumens <clumens> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dcantrell |
| Target Milestone: | --- | Flags: | clumens:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-12 14:06:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 18:26:42 UTC
W: dhcpv6 prereq-use /sbin/chkconfig, /sbin/service
W: dhcpv6 macro-in-%changelog defattr
%preun and %postun should use the same form of test for whether to run or not.
%attr(750,root,root) %dir %{_localstatedir}/lib/dhcpv6 should use %{name}.
These should use %{_sysconfdir}/sysconfig/... :
%config(noreplace) /etc/sysconfig/dhcp6s
%config(noreplace) /etc/sysconfig/dhcp6r
These should use %{_initrddir}/... :
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6s
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6r
You use $RPM_BUILD_ROOT in %clean, but %{buildroot} everywhere else.
The static library needs to be in a dhcpv6-static package.
libdhcp6client-devel needs to Require: pkgconfig, %{name} = %{version}-%{release}.
I fixed the above blockers and spun my changes in to the devel branch. Check it, yo. You missed using %{name} in the files section for dhcpv6_client, but otherwise
everything else looks okay.
Also, %{_sysconfdir} expands to /etc only, not /etc/sysconfig. So in the main
%files section, you still need to add sysconfig for the %config lines.
(In reply to comment #3) > You missed using %{name} in the files section for dhcpv6_client, but otherwise > everything else looks okay. Fixed. > Also, %{_sysconfdir} expands to /etc only, not /etc/sysconfig. So in the main > %files section, you still need to add sysconfig for the %config lines. *sigh*. Fixed. Rebuilding. |