Bug 225715

Summary:	Merge Review: echo-icon-theme
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	David Zeuthen <davidz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bdpepple, davidz, luya_tfz, mclasen
Target Milestone:	---	Flags:	bdpepple: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-04-20 17:05:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:31:22 UTC

Fedora Merge Review: echo-icon-theme

http://cvs.fedora.redhat.com/viewcvs/devel/echo-icon-theme/
Initial Owner: davidz

Comment 1 Brian Pepple 2007-02-04 15:58:34 UTC

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* Builds fine in mock.

Must Fix:
* Should be Requires(postun), not Requires(postub).
* rpmlint errors:
 W: echo-icon-theme macro-in-%changelog _datadir
 W: echo-icon-theme macro-in-%changelog build
 W: echo-icon-theme macro-in-%changelog buildroot

This should be an easy one to fix.  Just %% the macros in the ChangeLog.

Comment 2 Matthias Clasen 2007-02-06 03:28:19 UTC

I've fixed the changelog entries in 0.1-7.fc7

Comment 3 Brian Pepple 2007-02-12 16:42:20 UTC

Changes to spec look good.

+1 APPROVE.

Comment 4 Matthias Clasen 2007-04-20 17:05:52 UTC

Lets close this finally.