Bug 2257184

Can you patch Cargo.toml and build.rs so that the code path for the "buildtime_bindgen" feature is taken unconditionally? Otherwise the crate will use pre-generated bindings by default.

I.e. in Cargo.toml, the "bindgen" build-dependency should be non-optional, and in build.rs, the "not(buildtime_bindgen)" code path can be removed, and the "buildtime_bindgen" code path can be unconditional.

Additionally, the crate includes a bunch of shell scripts and files that are only useful for upstream. These should be excluded from getting installed into the -devel package.

(In reply to Fabio Valentini from comment #1)
> Can you patch Cargo.toml and build.rs so that the code path for the
> "buildtime_bindgen" feature is taken unconditionally? Otherwise the crate
> will use pre-generated bindings by default.
> 
> I.e. in Cargo.toml, the "bindgen" build-dependency should be non-optional,
> and in build.rs, the "not(buildtime_bindgen)" code path can be removed, and
> the "buildtime_bindgen" code path can be unconditional.
> 
> Additionally, the crate includes a bunch of shell scripts and files that are
> only useful for upstream. These should be excluded from getting installed
> into the -devel package.

Will do, thanks

Updated

Spec URL: https://salimma.fedorapeople.org/specs/rust-exacl.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-exacl-0.11.0-1.fc38.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6947605
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257184-rust-exacl/fedora-rawhide-x86_64/06947605-rust-exacl/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> Additionally, the crate includes a bunch of shell scripts and files that are only useful for upstream. These should be excluded from getting installed into the -devel package.

Looks like you missed this?

Please exclude at least the "ci" directory from the installed files, and possibly also "tests/*.sh", "tests/valgrind.supp", "tests/*.h", and also the "bindgen" directory, since it will end up unused unconditionally.

So something like this would be great:

```toml
[package]
# ...
exclude = [
    "/bindgen/",
    "/ci/",
    "/tests/*.sh",
    "/tests/*.h",
    "/tests/valgrind.supp",
]
# ...
```

Otherwise, package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (one test disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please note the comment above.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-exacl

(In reply to Fabio Valentini from comment #5)
> > Additionally, the crate includes a bunch of shell scripts and files that are only useful for upstream. These should be excluded from getting installed into the -devel package.
> 
> Looks like you missed this?
> 
> Please exclude at least the "ci" directory from the installed files, and
> possibly also "tests/*.sh", "tests/valgrind.supp", "tests/*.h", and also the
> "bindgen" directory, since it will end up unused unconditionally.
> 
> So something like this would be great:
> 
> ```toml
> [package]
> # ...
> exclude = [
>     "/bindgen/",
>     "/ci/",
>     "/tests/*.sh",
>     "/tests/*.h",
>     "/tests/valgrind.supp",
> ]
> # ...
> ```
> 
> Otherwise, package looks good to me.
> 
Ah yes, thanks!

Also regenerated the spec to include the bindgen feature subpackage (which does nothing)

FEDORA-2024-fcce63cc1c has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-fcce63cc1c

FEDORA-2024-fcce63cc1c has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-efb93bdca6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-efb93bdca6

FEDORA-2024-6e96541115 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e96541115

FEDORA-2024-6e96541115 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6e96541115 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e96541115

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-efb93bdca6 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-efb93bdca6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-efb93bdca6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-efb93bdca6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-6e96541115 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.