Bug 225730

Summary: Merge Review: eog
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Deji Akingunola <dakingun>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: behdad
Target Milestone: ---Flags: dakingun: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-11 01:37:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:33:22 UTC 
Fedora Merge Review: eog

http://cvs.fedora.redhat.com/viewcvs/devel/eog/
Initial Owner: besfahbo
Comment 1 Deji Akingunola 2007-04-14 17:30:51 UTC 
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* No file duplicates
* Package builds OK in Mock.
* Source matches upstream
md5sum: 32f4cd4cd3108522eccf0b8fd85c8bbd  eog-2.18.0.1.tar.bz2

rpmlint warnings (no so serious);
$ rpmlint eog-2.18.0.1-2.fc7.src.rpm
W: eog mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 78)
$ rpmlint eog-2.18.0.1-2.fc7.x86_64.rpm
W: eog non-conffile-in-etc /etc/gconf/schemas/eog.schemas

APPROVED.
Comment 2 Matthias Clasen 2007-08-11 01:37:59 UTC 
Review done.