Bug 225736

Summary: Merge Review: evince
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Kristian Høgsberg <krh>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: krh
Target Milestone: ---Flags: bdpepple: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-11 02:43:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:34:14 UTC
Fedora Merge Review: evince

http://cvs.fedora.redhat.com/viewcvs/devel/evince/
Initial Owner: krh

Comment 1 Brian Pepple 2007-02-03 16:20:09 UTC
Good:
* Tarball matches upstream
* Source URL is canonical
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* Post scriptlets conforms to packaging guidelines

Minor:
* You could use the disable-static flag with configure and not even bother with
building the static libs.
* Following rpmlint errors, which can be ignored:
W: evince non-conffile-in-etc /etc/gconf/schemas/evince-thumbnailer.schemas
W: evince non-conffile-in-etc /etc/gconf/schemas/evince.schemas

+1 Approve


Comment 2 Matthias Clasen 2007-08-11 02:43:59 UTC
Review done.