Bug 2257676

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6879308
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257676-python-snakemake-interface-storage-plugins/fedora-rawhide-x86_64/06879308-python-snakemake-interface-storage-plugins/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============


Looks good. XXX APPROVED XXX

Minor comments:

- pytest is only used when the package is not being bootstrapped, so the BR for it can also go into the conditional
- noticed we're not using the `-l` flag here with pyproject_save_files

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License". 17 files have unknown
     license. Detailed output of licensecheck in /home/asinha/dump/fedora-
     reviews/2257676-python-snakemake-interface-storage-
     plugins/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 16319 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
^
Tests pass
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-snakemake-interface-storage-plugins-3.0.0-1.fc40~bootstrap.noarch.rpm
          python-snakemake-interface-storage-plugins-3.0.0-1.fc40~bootstrap.src.rpm
=================================================================================== rpmlint session starts ===================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp5qi7xssq')]
checks: 31, packages: 2

==================================================== 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ====================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-snakemake-interface-storage-plugins.noarch: W: python-missing-require reretry
python3-snakemake-interface-storage-plugins.noarch: W: python-missing-require snakemake-interface-common
python3-snakemake-interface-storage-plugins.noarch: W: python-missing-require throttler
python3-snakemake-interface-storage-plugins.noarch: W: python-missing-require wrapt
 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 4 filtered, 0 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/snakemake/snakemake-interface-storage-plugins/archive/v3.0.0/snakemake-interface-storage-plugins-3.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 0df12018e035cc28fe335c80294242804ec8402e48f5110fb6e817ceae2b18a6
  CHECKSUM(SHA256) upstream package : 0df12018e035cc28fe335c80294242804ec8402e48f5110fb6e817ceae2b18a6


Requires
--------
python3-snakemake-interface-storage-plugins (rpmlib, GLIBC filtered):
    (python3.12dist(reretry) < 0.12~~ with python3.12dist(reretry) >= 0.11.8)
    (python3.12dist(snakemake-interface-common) < 2~~ with python3.12dist(snakemake-interface-common) >= 1.12)
    (python3.12dist(throttler) < 2~~ with python3.12dist(throttler) >= 1.2.2)
    (python3.12dist(wrapt) < 2~~ with python3.12dist(wrapt) >= 1.15)
    python(abi)



Provides
--------
python3-snakemake-interface-storage-plugins:
    python-snakemake-interface-storage-plugins
    python3-snakemake-interface-storage-plugins
    python3.12-snakemake-interface-storage-plugins
    python3.12dist(snakemake-interface-storage-plugins)
    python3dist(snakemake-interface-storage-plugins)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2257676
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Ocaml, R, fonts, C/C++, Perl, PHP, Java, Haskell, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Thank you for the review!

(In reply to Ankur Sinha (FranciscoD) from comment #2)
> Minor comments:
> 
> - pytest is only used when the package is not being bootstrapped, so the BR
> for it can also go into the conditional

Good catch; thanks. I’ll adjust this on import.

> - noticed we're not using the `-l` flag here with pyproject_save_files

Correct, because license files can only be handled automatically in %{pyproject_files} when the build backend marks them as License-File, which comes from draft PEP 639. Since poetry-core doesn’t do that, this package needs a manual %license LICENSE instead. Note that the following does not show the license file in the .dist-info directory:

$ rpm -qL -p results_python-snakemake-interface-storage-plugins/3.0.0/1.fc40/python3-snakemake-interface-storage-plugins-3.0.0-1.fc40~bootstrap.noarch.rpm 
/usr/share/licenses/python3-snakemake-interface-storage-plugins/LICENSE

https://release-monitoring.org/project/370847/

Fixing the assignee so releng-bot will give me a dist-git repo…

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snakemake-interface-storage-plugins

(In reply to Ben Beasley from comment #3)

> > - noticed we're not using the `-l` flag here with pyproject_save_files
> 
> Correct, because license files can only be handled automatically in
> %{pyproject_files} when the build backend marks them as License-File, which
> comes from draft PEP 639. Since poetry-core doesn’t do that, this package
> needs a manual %license LICENSE instead. Note that the following does not
> show the license file in the .dist-info directory:
> 
> $ rpm -qL -p
> results_python-snakemake-interface-storage-plugins/3.0.0/1.fc40/python3-
> snakemake-interface-storage-plugins-3.0.0-1.fc40~bootstrap.noarch.rpm 
> /usr/share/licenses/python3-snakemake-interface-storage-plugins/LICENSE


Aah! Makes sense.

FEDORA-2024-f770e5119a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f770e5119a

FEDORA-2024-f770e5119a has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.