Bug 2257727
| Summary: | Review Request: gnome-ponytail-daemon - A helper daemon intended for dogtail on Wayland | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | José Expósito <jexposit> |
| Component: | Package Review | Assignee: | Jiri Konecny <jkonecny> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkonecny, ofourdan, package-review |
| Target Milestone: | --- | Flags: | jkonecny:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://gitlab.gnome.org/ofourdan/gnome-ponytail-daemon | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-02-16 09:15:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
José Expósito
2024-01-10 16:11:38 UTC
RPM lint displayed this error during packaging:
gnome-ponytail-daemon-python.noarch:
E: incorrect-fsf-address /usr/lib/python3.12/site-packages/ponytail/ponytail.py
As suggested here:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
It was reported and fixed upstream:
https://gitlab.gnome.org/ofourdan/gnome-ponytail-daemon/-/merge_requests/8
cc @ofourdan
Copr build: https://copr.fedorainfracloud.org/coprs/build/6879711 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257727-gnome-ponytail-daemon/fedora-rawhide-x86_64/06879711-gnome-ponytail-daemon/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Systemd user unit service file(s) in gnome-ponytail-daemon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2010145 [details]
The .spec file difference from Copr build 6879711 to 6945898
Copr build: https://copr.fedorainfracloud.org/coprs/build/6945898 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257727-gnome-ponytail-daemon/fedora-rawhide-x86_64/06945898-gnome-ponytail-daemon/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in gnome-ponytail-daemon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2010146 [details]
The .spec file difference from Copr build 6945898 to 6946075
Copr build: https://copr.fedorainfracloud.org/coprs/build/6946075 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257727-gnome-ponytail-daemon/fedora-rawhide-x86_64/06946075-gnome-ponytail-daemon/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in gnome-ponytail-daemon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi Jose, a few points from the Python part. You should rename the package because Python guidelines requires naming in form of python3-* instead of python postfix: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming To solve this you can do ``%files -n python3-gnome-ponytail-daemon`` and use `-n` on other cases too. And you also need to add BuildRequires: python3-devel: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_buildrequire_python3_devel Also you shouldn't have dependency on python3 instead the recommendation is: ``` Packages SHOULD NOT have an explicit runtime dependency on python3. Instead of depending on python3, packages have an automatic dependency on python(abi) = 3.X when they install files to %{python3_sitelib} or %{python3_sitearch}, or they have an automatic dependency on /usr/bin/python3 if they have executable Python scripts, or they have an automatic dependency on libpython3.X.so.1.0() if they embed Python. ``` https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies Hi Jiri, Thanks a lot for your review, I truly appreciate it. (In reply to Jiri Konecny from comment #9) > Hi Jose, > > a few points from the Python part. > > You should rename the package because Python guidelines requires naming in > form of python3-* instead of python postfix: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming > > To solve this you can do ``%files -n python3-gnome-ponytail-daemon`` and use > `-n` on other cases too. Solved, thanks! The generated RPM now is "python3-gnome-ponytail-daemon-0.0.10-1.fc39.noarch.rpm". > And you also need to add BuildRequires: python3-devel: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_buildrequire_python3_devel This one is already included, but using the "python3_pkgversion" macro: BuildRequires: python%{python3_pkgversion}-devel I have seen this definition in other packages, for example: https://src.fedoraproject.org/rpms/vulkan-tools/blob/rawhide/f/vulkan-tools.spec#_15 > Also you shouldn't have dependency on python3 instead the recommendation is: > > ``` > Packages SHOULD NOT have an explicit runtime dependency on python3. > > Instead of depending on python3, packages have an automatic dependency on > python(abi) = 3.X when they install files to %{python3_sitelib} or > %{python3_sitearch}, or they have an automatic dependency on > /usr/bin/python3 if they have executable Python scripts, or they have an > automatic dependency on libpython3.X.so.1.0() if they embed Python. > ``` > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_dependencies Good point, I removed the "Requires: python3". Also, even the documentation suggest that informing upstream is the only required action for the "incorrect-fsf-address" lint error, since my patch has been already merged, I included it in the package. Queuing a new build with your suggested changes. Thanks again for the review!! [fedora-review-service-build] Created attachment 2014356 [details]
The .spec file difference from Copr build 6946075 to 6978832
Copr build: https://copr.fedorainfracloud.org/coprs/build/6978832 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257727-gnome-ponytail-daemon/fedora-rawhide-x86_64/06978832-gnome-ponytail-daemon/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in gnome-ponytail-daemon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks great to me now. Great job! :) The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-ponytail-daemon |