Bug 225779

Summary:	Merge Review: GConf2
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	Ray Strode [halfline] <rstrode>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bdpepple, rstrode
Target Milestone:	---	Flags:	bdpepple: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-08-11 02:40:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:40:59 UTC

Fedora Merge Review: GConf2

http://cvs.fedora.redhat.com/viewcvs/devel/GConf2/
Initial Owner: rstrode

Comment 1 Brian Pepple 2007-02-03 22:14:49 UTC

Good:
* Source URL is canonical
* Upstream source tarball verified
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.

Minor:
* Could use the -disable-static config flag, and not even bother building the
static libs.
* Duplicate BuildRequires: pkgconfig (by libxml2-devel), glib2-devel (by
ORBit2-devel), autoconf (by libtool), automake (by libtool), perl-XML-Parser (by
intltool)
* rpmlint errors (Non-blockers):
E: GConf2-devel tag-not-utf8 %changelog
W: GConf2-devel no-documentation

Comment 2 Matthias Clasen 2007-02-04 00:58:11 UTC

I've added --disable-static now, and fixed one gtk-doc related directory
ownership problem that you have overlooked.

Comment 3 Matthias Clasen 2007-08-11 02:40:54 UTC

Review done.