Bug 2258087

Summary:	Change Firefox desktop file
Product:	[Fedora] Fedora	Reporter:	Aoife Moloney <amoloney>
Component:	Changes Tracking	Assignee:	Martin Stransky <stransky>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	40	CC:	awilliam, renault, stransky
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-29 09:29:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2105403

Description Aoife Moloney 2024-01-12 15:10:55 UTC

This is a tracking bug for Change: Change Firefox desktop file
For more details, see: https://fedoraproject.org/wiki/Changes/RenameFirefoxDesktopFile

Recent Firefox desktop file (firefox.desktop) does not comply with DBus/Gnome search provider rules thus Firefox can't provide DBus Gnome search service.

If you encounter a bug related to this Change, please do not comment here. Instead create a new bug and set it to block this bug.

Comment 1 Martin Stransky 2024-01-15 08:57:04 UTC

Fixed in rawhide.

Comment 2 Adam Williamson 2024-02-21 02:33:27 UTC

Change bugs should only be closed by the wrangler according to the process, I think. The appropriate status if it's all "done" so far as the maintainer's concerned is ON_QA.

Comment 3 Couret Charles-Antoine 2024-04-02 08:14:04 UTC

I'm using an up to date Fedora Linux 40, and it looks like this feature does not work.

When searching with GNOME I got this error:
systemd[2817]: Started dbus-:1.2-org.mozilla.firefox.SearchProvider.
systemd[2817]: dbus-:1.2-org.mozilla.firefox.SearchProvider: Main process exited, code=exited, status=1/FAILURE
systemd[2817]: dbus-:1.2-org.mozilla.firefox.SearchProvider: Failed with result 'exit-code'.
gnome-shell[3047]: Received error from D-Bus search provider org.mozilla.firefox.desktop: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Could not activate remote peer: unit failed.

And no outputs on GNOME interface. All settings look correct.

Comment 4 Martin Stransky 2024-04-02 08:56:20 UTC

(In reply to Couret Charles-Antoine from comment #3)
> I'm using an up to date Fedora Linux 40, and it looks like this feature does
> not work.
> 
> When searching with GNOME I got this error:
> systemd[2817]: Started
> dbus-:1.2-org.mozilla.firefox.SearchProvider.
> systemd[2817]: dbus-:1.2-org.mozilla.firefox.SearchProvider:
> Main process exited, code=exited, status=1/FAILURE
> systemd[2817]: dbus-:1.2-org.mozilla.firefox.SearchProvider:
> Failed with result 'exit-code'.
> gnome-shell[3047]: Received error from D-Bus search provider
> org.mozilla.firefox.desktop: Gio.DBusError:
> GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Could not activate
> remote peer: unit failed.
> 
> And no outputs on GNOME interface. All settings look correct.

Yes, it needs also code changes on Firefox side which is not finished yet.

Comment 5 Couret Charles-Antoine 2024-04-02 09:05:45 UTC

Is it planned to be fixed after F40 release? Just to know how this feature must be described for the release notes because the description of this change is mentioning that the feature itself would work. At this moment it's just a step to fix it in the future, maybe in future Firefox release.

Comment 6 Martin Stransky 2024-04-02 09:15:39 UTC

(In reply to Couret Charles-Antoine from comment #5)
> Is it planned to be fixed after F40 release? Just to know how this feature
> must be described for the release notes because the description of this
> change is mentioning that the feature itself would work. At this moment it's
> just a step to fix it in the future, maybe in future Firefox release.

Yes, it's going to be fixed in future Firefox release. Firefox needs to implement org.freedesktop.Application DBus interface now. When this change request was added, the search provider worked without it (desktop file change was enough).

Comment 7 Martin Stransky 2024-04-02 09:17:17 UTC

(In reply to Couret Charles-Antoine from comment #5)
> Is it planned to be fixed after F40 release? Just to know how this feature
> must be described for the release notes because the description of this
> change is mentioning that the feature itself would work. At this moment it's
> just a step to fix it in the future, maybe in future Firefox release.

Yes, this is a step to future fix. A global system-wide change is done and we need to update Firefox itself which can be done in next Firefox release and doesn't need any system wide changes.

Comment 8 Couret Charles-Antoine 2024-04-02 09:20:32 UTC

Ok, this is clear, thanks for the explanation and "good luck" ;)

Comment 9 Aoife Moloney 2024-04-29 09:29:27 UTC

F40 was released on 2024-04-23, so I am closing this tracker. If this Change was not completed, please notify me ASAP.