Bug 225820

Summary:	Merge Review: gnome-keyring-manager
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	Alexander Larsson <alexl>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	alexl
Target Milestone:	---	Flags:	dakingun: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-08-10 20:43:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:51:32 UTC

Fedora Merge Review: gnome-keyring-manager

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-keyring-manager/
Initial Owner: alexl

Comment 1 Deji Akingunola 2007-02-08 15:15:12 UTC

GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Spec file clean and legible
 * Handles locales appropriately
 * Buildrequires properly listed
 * rpmlint silent on srpm and a warning that can be ignored on the binary
[deji@agape reviews]$ rpmlint gnome-keyring-manager-2.17.0-1.fc7.x86_64.rpm
W: gnome-keyring-manager non-conffile-in-etc
/etc/gconf/schemas/gnome-keyring-manager.schemas
 * Source file matches upstream
8dc9c133ccdfb2729898a05afa177a0d  gnome-keyring-manager-2.17.0.tar.bz2

 NEEDSWORK:
 * Complete url to the SOURCE is not provided.

APPROVED.

Comment 2 Deji Akingunola 2007-02-08 15:18:53 UTC

Re-assigning back to the owner

Comment 3 Matthias Clasen 2007-02-08 20:41:35 UTC

* Thu Feb  8 2007 Matthias Clasen <mclasen> - 2.17.0-2
- Package review cleanup

Comment 4 Matthias Clasen 2007-08-10 20:43:52 UTC

This review is done.