Bug 2258652

Summary: Review Request: rust-b3sum - Command line implementation of the BLAKE3 hash function
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/b3sum
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-19 18:42:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ben Beasley 2024-01-16 20:36:31 UTC
Spec URL: https://music.fedorapeople.org/rust-b3sum.spec
SRPM URL: https://music.fedorapeople.org/rust-b3sum-1.5.0-1.fc40.src.rpm

Description:

A command line implementation of the BLAKE3 hash function.

Fedora Account System Username: music

Koji scratch builds:

F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=111848976
F39: https://koji.fedoraproject.org/koji/taskinfo?taskID=111849022
F38: https://koji.fedoraproject.org/koji/taskinfo?taskID=111849030

Comment 1 Fedora Review Service 2024-01-16 20:37:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6910687
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258652-rust-b3sum/srpm-builds/06910687/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-01-16 21:20:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6910851
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258652-rust-b3sum/fedora-rawhide-x86_64/06910851-rust-b3sum/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-01-19 16:33:11 UTC
Thank you for fixing the CC0-1.0 stuff with a patch, I would have done it in the same way.

That reminds me, I need to fix the metadata for those few Rust crates that still have "CC0-1.0 OR ..." licenses ...

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora (CC0-1.0 option removed)
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Ben Beasley 2024-01-19 16:44:55 UTC
Thank you for the review!

I updated the existing release-monitoring project: https://release-monitoring.org/project/283971/

Comment 6 Fedora Admin user for bugzilla script actions 2024-01-19 18:20:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-b3sum

Comment 7 Fedora Update System 2024-01-19 18:39:22 UTC
FEDORA-2024-7376ca2506 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7376ca2506

Comment 8 Fedora Update System 2024-01-19 18:42:26 UTC
FEDORA-2024-7376ca2506 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-01-19 19:26:36 UTC
FEDORA-2024-ae94336e03 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ae94336e03

Comment 10 Fedora Update System 2024-01-19 21:19:28 UTC
FEDORA-2024-3d2ae6166a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3d2ae6166a

Comment 11 Fedora Update System 2024-01-20 03:25:18 UTC
FEDORA-2024-ae94336e03 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ae94336e03 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ae94336e03

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-20 04:25:58 UTC
FEDORA-2024-3d2ae6166a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3d2ae6166a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3d2ae6166a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-01-28 03:08:01 UTC
FEDORA-2024-ae94336e03 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-01-29 04:30:45 UTC
FEDORA-2024-3d2ae6166a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.